-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121351/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 11:40 a.m.)
Review request for Okular, Print Manager, Daniel Nicoletti, and Thomas Lübking.
Changes
-------
Adding more reviewers that are somewhat related to printing or dialog modality.
Bugs: 328014
http://bugs.kde.org/show_bug.cgi?id=328014
Repository: print-manager
Description
-------
[Commit
1595ef0614f824a6a871d51327eff3a108e6e251](https://projects.kde.org/projects/kde/kdeutils/print-manager/repository/revisions/1595ef0614f824a6a871d51327eff3a108e6e251)
(a partial fix for bug 314633) changed the password dialog to be non-modal.
But the printer configuration dialog is still modal, so if a password is needed
to apply/save the configuration it cannot be entered because the password
dialog cannot get focus.
This patch sets the configuration dialog to be non-modal as well to prevent
this problem.
Diffs
-----
configure-printer/ConfigureDialog.cpp ace91a2
Diff: https://git.reviewboard.kde.org/r/121351/diff/
Testing
-------
Open the "Printer" KCM in systemsettings, select a printer, click on
"Configure", change some setting and click "Apply" or "OK".
A password dialog appears (unless you have the necessary privileges to change
the CUPS settings of course), this has focus and you can actually enter the
username/password now whereas you could not without this patch.
Also tested by other users and included in openSUSE's official packages, see
https://bugzilla.opensuse.org/show_bug.cgi?id=889187#c7.
Thanks,
Wolfgang Bauer
_______________________________________________
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
