-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115283/
-----------------------------------------------------------
(Updated March 16, 2015, 11:21 p.m.)
Status
------
This change has been marked as submitted.
Review request for Okular and Albert Astals Cid.
Changes
-------
Submitted with commit 1eafe4feb151c713e8f7747164348c25886480bf by Albert Astals
Cid on behalf of Saheb Preet Singh to branch master.
Bugs: 326844
http://bugs.kde.org/show_bug.cgi?id=326844
Repository: okular
Description
-------
okular do not have a feature to resize the current window to the current page
size.
The bug is solved upto some extent, the window is resizing as desired.
resize method of qwidget class is used to resize the window.
The window is resizing as required but sometimes it doesn't resizes . It has
to be moved by mouse and then again click on the button in the menu to resize
the window again. Once it is moved by mouse, it works fine. Now, when the zoom
level is changed, the problem starts again.
I think the problem occurs due to something happening in the other portion of
the code.
I searched about it on the internet and nobody was able to answer the solution
to people with same problem. There are some alternative solutions to the
problem:-
==> Use set geometry instead of resize which works fine. but would have to be
taken care of the size of the screen and the original position of the window.
Also, repainting the portion outside the window when the window is resized to a
smaller window.
==> Use a timer which will signal a slot which in turn will resize the window,
but that might require qsignalmapper to map the width and height to the slot. (
I didn't tried this solution ).
The best solution i could find on the internet is this
http://qt-project.org/forums/viewthread/25648
Also, there is one more issue, the fit window to page button in the view menu
is enabled by default. It should not be enabled when no document is open. Where
should the code for enabling this button should be implemented.
Diffs
-----
doc/index.docbook 3237849
part.h 594eb44
part.cpp 36438af
shell/shell.h 224acfe
shell/shell.cpp f7675fd
ui/pageview.h a8adb2c
ui/pageview.cpp 2dd8cf1
ui/sidebar.h cf5dfc6
ui/sidebar.cpp 0c722a9
Diff: https://git.reviewboard.kde.org/r/115283/diff/
Testing
-------
tested when
==> window is maximized and restored.
==> thumbnails, table of content are opened and closed.
==> various toolbars are shown and hidden.
==> for all the zoom levels shown in the toolbar and custom zoom level (
example 123.23% ).
Thanks,
Saheb Preet Singh
_______________________________________________
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
