Hi, Today, I added a search bar on the layers list. The searchbar is not searching appropriate results. I was stuck at this.
I hope I will figure it out by tomorrow. Best, Saheb Preet Singh On 5/10/15, Albert Astals Cid <aa...@kde.org> wrote: > El Dissabte, 9 de maig de 2015, a les 21:48:32, saheb preet singh va > escriure: >> Hi, >> >> Previously, I had done a small proof of concept for implementing the >> layers >> list in the left side bar. Okular was crashing on closing the document, >> for >> some reasons. >> >> Today, I was restructuring and properly implementing the list. I was able >> to populate the list in a list view and enable or disable the layers >> button >> depending on if they are present in the document. Also, I fixed the >> crashing of the okular in my previous code on closing document. >> >> Here is a screen shot of the work so far:- >> >> http://ctrlv.in/572212 >> >> Note:- Layers icon and some styling is still to be done. > > Check in oxygen/breeze icon sets, probably someone needed a layer-y icon at > some point > >> Now, I have some doubts. >> >> Firstly, where should I show my code. Should I post it on review board as >> a >> diff or should I wait for the contributor account on kde and commit push >> my >> code at regular intervals? > > As said, push to your own branch in the okular repo. Ideally it'd even make > sense to have various branches per feature, since they seem to be quite > isolated and probably won't need much dependencies between themselves. > >> Secondly, I have implemented the layers view directly through subclass of >> QAbstractItemModel ( OptionalContentModel ) provided by the backend to >> render the view. Should I create a layers model as done in case of table >> of >> content model( TOCModel ) for abstraction between different backends or >> should I assume that each backend or its generator would return me some >> subclass of QAbstractItemModel? > > Assuming we'll have an QAbstractItemModel is ok, just make sure you document > clearly the roles, etc. we expect from the model. > > Actually the Okular::DocumentSynopsis is a QDomDocument, it happens to be > that > XML was all the rage back when we wrote this in early 2000, not really the > best of the ideas i'd say :D > > Cheers, > Albert > >> >> Best, >> Saheb Preet Singh >> >> On Fri, May 8, 2015 at 11:02 PM, Albert Astals Cid <aa...@kde.org> wrote: >> > El Divendres, 8 de maig de 2015, a les 13:46:52, saheb preet singh va >> > >> > escriure: >> > > Hello Everyone, >> > > >> > > I have just started writing my blog for my working experience with kde >> > >> > this >> > >> > > summer. >> > > >> > > You can find the blog at http://sahebpreet-kde.blogspot.in/ >> > >> > Cool, you should add yourself to planetkde. >> > >> > Cheers, >> > >> > Albert >> > >> > > Thanks, >> > > Saheb Preet Singh >> > > >> > > On Tue, May 5, 2015 at 12:04 AM, Albert Astals Cid <aa...@kde.org> >> > >> > wrote: >> > > > El Dilluns, 4 de maig de 2015, a les 16:42:33, saheb preet singh va >> > > > >> > > > escriure: >> > > > > On Mon, May 4, 2015 at 3:52 AM, Albert Astals Cid <aa...@kde.org> >> > >> > wrote: >> > > > > > El Dijous, 30 d'abril de 2015, a les 15:11:45, saheb preet singh >> > > > > > va >> > > > > > >> > > > > > escriure: >> > > > > > > Hello Everyone, >> > > > > > >> > > > > > Hi! >> > > > > > >> > > > > > > Thank you for accepting my proposal in GSOC 2015. >> > > > > > >> > > > > > Congrats, now let's make us both proud of the result :) >> > > > > > >> > > > > > > I am really excited to contribute in kde and okular in the >> > > > > > > summer >> > > > > > >> > > > > > vacation >> > > > > > >> > > > > > > this time. This is my first time participation in GSOC. >> > > > > > > >> > > > > > > My project is about adding tags, layers and linearization >> > >> > support in >> > >> > > > > > okular. >> > > > > > >> > > > > > > My development environment is ready and I have been working on >> > >> > the >> > >> > > > > > > okular >> > > > > > > code. >> > > > > > >> > > > > > Great :) >> > > > > > >> > > > > > > I would like to know how should I proceed further and what >> > >> > should be >> > >> > > > my >> > > > >> > > > > > > first steps in GSOC program? >> > > > > > >> > > > > > Choose one of the things and start working on it, on a branch in >> > >> > the >> > >> > > > repo >> > > > >> > > > > > and >> > > > > > blog about it :) >> > > > > >> > > > > Should I create a new branch or use any existing? >> > > > >> > > > Create a new one. >> > > > >> > > > > I will start blogging soon. >> > > > > >> > > > > > I think layers is probably the easiest so i'd suggest starting >> > >> > there. >> > >> > > > > I just tried to implement layers feature and was able to list the >> > >> > layers >> > >> > > > > present in document in the left side bar. Although, I did it in a >> > >> > very >> > >> > > > > adhoc way. We can discuss further on code structure and proper >> > > > > implementation. >> > > > > >> > > > > We should find a time to do an IRC meeting to kickstart on this. >> > > > > Does >> > > > >> > > > 18:00 >> > > > >> > > > > > UTC work for you? Any specific day of the week? >> > > > > >> > > > > Yes, 18:00 UTC is ok for me. Is thursday or friday ok for you? >> > > > >> > > > Friday is good :) >> > > > >> > > > Anyone else is obviously welcome. >> > > > >> > > > #okular channel on irc.freenode.net >> > > > >> > > > Cheers, >> > > > >> > > > Albert >> > > > >> > > > > Thanks, >> > > > > Saheb Preet Singh >> > > > > >> > > > > Cheers, >> > > > > >> > > > > > Albert >> > > > > > >> > > > > > > Thanks, >> > > > > > > Saheb Preet Singh >> > > > > > >> > > > > > _______________________________________________ >> > > > > > Okular-devel mailing list >> > > > > > Okular-devel@kde.org >> > > > > > https://mail.kde.org/mailman/listinfo/okular-devel >> > >> > _______________________________________________ >> > Okular-devel mailing list >> > Okular-devel@kde.org >> > https://mail.kde.org/mailman/listinfo/okular-devel > > _______________________________________________ > Okular-devel mailing list > Okular-devel@kde.org > https://mail.kde.org/mailman/listinfo/okular-devel > _______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel