----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123466/#review80262 -----------------------------------------------------------
Ship it! I see, thanks - Albert Astals Cid On abr. 22, 2015, 1:09 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123466/ > ----------------------------------------------------------- > > (Updated abr. 22, 2015, 1:09 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > ------- > > This seems to be required with KPluginFactory and Qt5 since without it > KPluginFactory::create<Okular::Generator>() always returns null. > > For some reason this requires a complete rebuild before generatorstest > passes. > > > Also add a test to see that generators can be loaded > > > Diffs > ----- > > generators/djvu/generator_djvu.h f056fecf3d7831e34693f822c2cd9dc40ccf4c78 > generators/comicbook/generator_comicbook.h > a521abb7d4ba1f1fbab7f102c9849221bea35019 > generators/chm/generator_chm.h e9f2a8e8f69a1d7592cdfdaf6fb5bdc91d0d2ca2 > core/document.cpp 2d4e85d86bb338226b8870ff8be1c790be9a937b > autotests/generatorstest.cpp PRE-CREATION > autotests/CMakeLists.txt 0a0f546203536f65a5b6c72f81c05c58809216ce > generators/dvi/generator_dvi.h 1fac6b3651bc76c17ed15b2b821553c15534e85b > generators/epub/generator_epub.h 3da0191e4074c876805f9c39d2473d7f4f7ce161 > generators/fax/generator_fax.h 66d83c81733b20db8493dba56ea56f4f13f98eca > generators/fictionbook/generator_fb.h > fc6dc95a4d6d439d2eae84428c5db8243fc548be > generators/kimgio/generator_kimgio.h > feb642c4707d14a7eed1fe7fe6024cc7adf9e09d > generators/mobipocket/generator_mobi.h > 70c3150d34856283a7acd0cb735f9f4ac576de56 > generators/ooo/generator_ooo.h 2bfa81c9c07d8de0e7d81e790aea749c43475b9a > generators/plucker/generator_plucker.h > ff96fbbfce86cb01d02a895fa1f937df366a33bd > generators/poppler/generator_pdf.h f3226b2684846b38ca99839a07a7f8cfb7c618a1 > generators/spectre/generator_ghostview.h > 914a51810aca376c76efe3ba153bafef427e3972 > generators/tiff/generator_tiff.h e2d0d544d0618748bfe85997a1e3ea7c1938dd84 > generators/txt/generator_txt.h 9a972c07e1f7e66f36a3c69f9ddd923f6a2fa72b > generators/xps/generator_xps.h af8d3373afc2aa8d4d6bd407ab0f3b5b94e07bf6 > > Diff: https://git.reviewboard.kde.org/r/123466/diff/ > > > Testing > ------- > > Loading didn't work before, does not. Requires a full rebuild. > > > Thanks, > > Alex Richardson > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
