----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124027/#review82383 -----------------------------------------------------------
> Okular is being built in C++11 mode anyway Is it? Can you point me where we enable that? - Albert Astals Cid On jun. 8, 2015, 8:59 a.m., Jan Kundrát wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124027/ > ----------------------------------------------------------- > > (Updated jun. 8, 2015, 8:59 a.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > The old auto_ptr was used for simple RAII. None of the auto_ptr flaws > were apparent in that context, but given that that class is actively > deprecated and that compilers warn about its use, it's better to switch > to its drop-in replacement. > > My reason for not using QScopedPointer is that the C++11 version works > well enough, Okular is being built in C++11 mode anyway, unique_ptr > works on the KF5-minimal-mandated-compilers according to their docs, and > therefore there's no point in using something with a different API > (QScopedPointer) just because its name begins with a Q. > > > Diffs > ----- > > core/document.cpp 9d1248871a495100b055157b2b18d6b9a7c5f103 > generators/comicbook/directory.cpp ec023b37ffa1b12bf91e954fdfea5dbdf9d50b0c > generators/comicbook/unrar.cpp 10cda631d885e235c04aa3772f9f542fa2ed2b5c > part.cpp 5b03e56e194bf84a9f02ceaf94cad13526715157 > ui/guiutils.cpp 3bf3ad64b57396792c3aa33298265561ee35ed1a > > Diff: https://git.reviewboard.kde.org/r/124027/diff/ > > > Testing > ------- > > > Thanks, > > Jan Kundrát > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel