> On July 18, 2015, 8:45 p.m., Albert Astals Cid wrote: > > CMakeLists.txt, line 219 > > <https://git.reviewboard.kde.org/r/124381/diff/1/?file=385839#file385839line219> > > > > What is EXPORT_NAME?
EXPORT_NAME is the name of the target in the Config.cmake file. So that users can do a target_link_libraries(foo Okular::Core) instead of Okular::okularcore. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124381/#review82622 ----------------------------------------------------------- On July 18, 2015, 4:34 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124381/ > ----------------------------------------------------------- > > (Updated July 18, 2015, 4:34 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > ------- > > --- > > Install Okular5Config.cmake instead of OkularConfig.cmake > > Otherwise Qt4 projects that have a find_package(Okular) can break > because CMake then selects moc from Qt5 which won't work > > --- > > Make the KF5 okular library coinstallable with the KDE4 version > > The KF5 based library has been renamed to libOkular5Core.so so that > both can coexist in /usr/lib(64) > > --- > > Set the CMake target name from Okular::okularcore to Okular::Core > > > Diffs > ----- > > CMakeLists.txt 3b882f31a853887c60cb247342a34b78ca0a20a1 > OkularConfig.cmake.in 2b610fe156d8b52adba6075a2852e1507a3d73a2 > > Diff: https://git.reviewboard.kde.org/r/124381/diff/ > > > Testing > ------- > > Patched Kile to use find_package(Okular5), everything seems to work > > > Thanks, > > Alex Richardson > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel