----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124964/ -----------------------------------------------------------
Review request for Okular and Albert Astals Cid. Bugs: 351889 http://bugs.kde.org/show_bug.cgi?id=351889 Repository: okular Description ------- Ensure pixmap of proper resolution used when switching viewmode Diffs ----- ui/pageview.cpp dc9eab8301b05e57bfdd537d47b33da594759573 Diff: https://git.reviewboard.kde.org/r/124964/diff/ Testing ------- Steps to repro: 1) resize app window to be narrow enough so that in facing pages viewmode page dimensions are reduced. 2) switch to facing pages mode. 3) switch back to single page mode. Expected Result: Single page is shown at proper resolution Actual Result: Single page is displayed with proper dimensions but is actually a scaled-up version of a lower resolution pixmap. I've verified that this fixes the issue. Note that adding this line after slotRelayoutPages() is sprinkled all over pageview.cpp, always affixed with a "we may not need to do this" - Code Smell. Thanks, Jake Linder
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel