----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125742/ -----------------------------------------------------------
Review request for Okular. Repository: okular Description ------- okularplugin target from mobile/components suffers from the same problem as okularpart in https://git.reviewboard.kde.org/r/125741/ But the cause is a bit different now. okularplugin uses settings.cpp generated by KConfig and its header declares Settings class with OKULARCORE_EXPORT. For okularplugin target this macro gets expanded to __declspec(dllimport) and it makes linker to look for Settings class symbols in okularcore. Fix this by tricking VS that we are building okularcore target. Diffs ----- mobile/components/CMakeLists.txt a5db04e8e40631452adfee3ed41083724356c6c5 Diff: https://git.reviewboard.kde.org/r/125742/diff/ Testing ------- Thanks, Gleb Popov
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
