----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126192/ -----------------------------------------------------------
Review request for Okular and Albert Astals Cid. Repository: okular Description ------- --- Try fixing mainshelltest: one more passes now QUrl is not automatically exposed to DBus so the DBus call would fail. Changed the parameter to QString instead so that DBus invocation works. --- Fix crash due to out of bounds list access Probably due to differences between KTabWidget and QTabWidget --- mainshelltest: set QStandardPaths to test mode --- mainshelltest: reduce number of test failures from 15 to 4 Unlike KCmdLineArgs QCommandLineParser treats options starting with a single minus as multiple short options so we need to make sure we use two for the long options. E.g. okular -unique will fail with the following error: Unknown options: u, n, i, q, u, e. --- Fix docdata saving and added a warning message if it fails If the ~/.local/okular/docdata directory didn't exist previously creating the docdata file would fail as there are missing paths. It seems that KStandardDirs used to create the okular/docdata directory automatically, with QStandardPaths we have to create it manually. mainshelltest is down to one failed test now --- Fix final test case in mainshelltest as we call QProcess::terminate the exit code will not be 0 Diffs ----- shell/shell.h c16a0b266008c3217f908aa92cc42103d62c5f4a shell/shell.cpp e69ecbb5e1bde36dbd00e5ff05cdad4e3d2a5f8d core/document.cpp 04a29fd1be29f1c464b2d9d08ae20ba9e0b937ef autotests/mainshelltest.cpp 118cfbc1c18fdefad5f933d6de4b85820bfb7379 shell/okular_main.cpp fdee69458baa0b111be9613e844834b7069fca00 Diff: https://git.reviewboard.kde.org/r/126192/diff/ Testing ------- mainshelltest now passes and documents are opened where I last viewed them Thanks, Alex Richardson
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel