> On Jan. 24, 2016, 1:56 p.m., Alex Richardson wrote: > > Ping? would be nice to have docdata saving working again. (And having the > > test passing on the CI) > > Paul Hollensen wrote: > In Shell::openDocument, what is the purpose of QUrl::StrictMode? > This is causing okular to fail to open pdfs with spaces in the filename > for me. > Works fine with this bit commented.
Would you please open a bug in bugs.kde.org about this? Put [frameworks] at the beginning of the subject so it can be identified easily. - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126192/#review91520 ----------------------------------------------------------- On Jan. 30, 2016, 4:32 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126192/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2016, 4:32 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > ------- > > --- > > Try fixing mainshelltest: one more passes now > > QUrl is not automatically exposed to DBus so the DBus call would fail. > Changed the parameter to QString instead so that DBus invocation works. > > --- > > mainshelltest: set QStandardPaths to test mode > > --- > > Parse command line flags with a single dash as a long option > > Unlike KCmdLineArgs QCommandLineParser treats options starting with a > single minus as multiple short options by default. > > Previously okular -unique would fail with the following error: > Unknown options: u, n, i, q, u, e. > > Also changed mainshelltest to use two dashes in case this behaviour > should change in the future. > > mainshelltest failures have been reduced from 15 to 4 by this commit. > > --- > > Fix docdata saving and added a warning message if it fails > > If the ~/.local/okular/docdata directory didn't exist previously > creating the docdata file would fail as there are missing paths. > > It seems that KStandardDirs used to create the okular/docdata directory > automatically, with QStandardPaths we have to create it manually. > > mainshelltest is down to one failed test now > > --- > > Fix final test case in mainshelltest > > as we call QProcess::terminate the exit code will not be 0 > > > Diffs > ----- > > autotests/mainshelltest.cpp 118cfbc1c18fdefad5f933d6de4b85820bfb7379 > core/document.cpp 145d84c772e8a64ea7e7891b00ba230e0147c609 > shell/main.cpp b426746af1646261a4bddbdcbe7a3cf1e70618b7 > shell/okular_main.cpp fdee69458baa0b111be9613e844834b7069fca00 > shell/shell.h c16a0b266008c3217f908aa92cc42103d62c5f4a > shell/shell.cpp e69ecbb5e1bde36dbd00e5ff05cdad4e3d2a5f8d > > Diff: https://git.reviewboard.kde.org/r/126192/diff/ > > > Testing > ------- > > mainshelltest now passes and documents are opened where I last viewed them > > > Thanks, > > Alex Richardson > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel