----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127328/ -----------------------------------------------------------
(Updated March 16, 2016, 10:58 a.m.) Status ------ This change has been marked as submitted. Review request for Okular, Aleix Pol Gonzalez, Alex Richardson, and Gleb Popov. Changes ------- Submitted with commit df0c41212fad2ade6f73b103e57062f99ae20de9 by Thomas Friedrichsmeier to branch frameworks. Repository: okular Description ------- Three parts to this patch: 1) The plaform #ifdef in interfaces/viewerinterface.h is platform, not compiler-specific. 2) When compiling okularplugin, the existing definition of okularpart_EXPORTS on the generated settings.cpp does not work with MinGW, for reasons that I do not understand. Setting the definition on the whole target, instead, works. 3) The okularpart lib will automatically be named libokularpart, and subsequently not be found when trying to load it via KPluginLoader. Tell cmake to drop the "lib"-prefix. See also: - Discussion on list https://mail.kde.org/pipermail/okular-devel/2016-March/022480.html - A previous review request addressed issue 2 for MSVC https://git.reviewboard.kde.org/r/125742/ Diffs ----- CMakeLists.txt e17bc25 interfaces/viewerinterface.h e9e76a2 mobile/components/CMakeLists.txt e09326a Diff: https://git.reviewboard.kde.org/r/127328/diff/ Testing ------- Builds on Windows with MinGW. Starts, and loads okularpart, successfully. Thanks, Thomas Friedrichsmeier
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
