> On July 13, 2016, 2:04 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > did you run the tests (especially the mainshelltest, which has tests for > > the "unique" behaviour?
but fwiw, your description of the behaviour seems correct to me, but I think it should be up to Albert to decide what should actually happen. - Martin Tobias Holmedahl ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128436/#review97351 ----------------------------------------------------------- On July 13, 2016, 10:56 a.m., Olivier Churlaud wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128436/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 10:56 a.m.) > > > Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl > Sandsmark. > > > Repository: okular > > > Description > ------- > > As I didn't know what unique was exactly for, here is what I considered (if > I'm wrong, please correct me): > > User wants only one instance of okular so he starts it with --unique flag. > From now on, every time he starts okular without the flag, it will raise the > current instance. Opening a new file /should/ open a tab (currently > overwrites the last one). > > In my opinion, if another --unique is started, it should drop the --unique > (it is not the case now: it starts a new instance). > > Still to do as I see it: > - open new documents in new tabs by default (in unique mode) > - allow opening several documents at once in unique mode > - Drop --unique if another session already exist > > > Diffs > ----- > > shell/okular_main.cpp 2285f64 > > Diff: https://git.reviewboard.kde.org/r/128436/diff/ > > > Testing > ------- > > Compile, behave as described above. > > > Thanks, > > Olivier Churlaud > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel