----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128441/ -----------------------------------------------------------
(Updated July 13, 2016, 9:48 p.m.) Status ------ This change has been marked as submitted. Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl Sandsmark. Changes ------- Submitted with commit dd8fa351ce87be2b46243e5de641b9c104a024cc by Olivier CHURLAUD to branch frameworks. Repository: okular Description ------- The fonts were not scanned anymore in poppler because the function was commented. 2 things to review: 1) I removed in the equality comparaison of FontInfo the native identifier. I add to do this because it was always false. If it's wrong to do this, how should I do? 2) It's very unefficient to recreate a page iterator for each page instead of iterating over the pages directly. (see the code) Diffs ----- core/document.cpp af842e1 core/fontinfo.cpp 59ea79f generators/poppler/generator_pdf.cpp 3b53f41 Diff: https://git.reviewboard.kde.org/r/128441/diff/ Testing ------- No influence on tests Compile, show the fonts Thanks, Olivier Churlaud
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
