----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127541/#review97650 -----------------------------------------------------------
I don't want to be pushy, I know that time is scarce and people (including me) have a lot of other things to do, but still: is there anything else that needs to be fixed in this patch? Is my explanation of the usecase clear and convincing enough? - Jonathan Verner On April 6, 2016, 8:01 p.m., Jonathan Verner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127541/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 8:01 p.m.) > > > Review request for Okular. > > > Bugs: 361292 > http://bugs.kde.org/show_bug.cgi?id=361292 > > > Repository: okular > > > Description > ------- > > This patch allows the user to import annotations from a different document > into the currently opened document. > While importing, it tries to avoid adding duplicate annotations by looking > whether an annotation with > the same uniqueName is not already present on the given page. It doesn't > check whether the currently opened > document corresponds to the one where comments are imported from. It just > loops over the pages starting > from 0 to the minimum of the size of the two files and for each page it > imports the annotations. > > > Diffs > ----- > > core/document.h 63f58741bd6680a673945a7b7c05a10130968beb > core/document.cpp 6953b1fb0dc29a375be7ff331a2a2bccce975366 > kdocumentviewer.h f99c69ef4ac8dbfb7ee600df7f97db7c62a409ab > part.h 44d032e496aacde0b8c239ed344a0f3eb39fa09b > part.cpp d8f1750f33a903c1734857042b601b52d8d8e1f2 > shell/shell.h fea80acfbf91968d90babd281d199341b6370bbd > shell/shell.cpp d80def41c2c17364557402654205a5c705a29d1f > shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 > tests/data/annots.pdf PRE-CREATION > tests/mainshelltest.cpp a044895c1935c587552e875a98627e58d19ed443 > > Diff: https://git.reviewboard.kde.org/r/127541/diff/ > > > Testing > ------- > > Tested both manually on several files and also provided a simple automatic > test in mainshelltest.cpp. > > > Thanks, > > Jonathan Verner > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
