----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130219/#review103582 -----------------------------------------------------------
Thanks for contributing to Okular :) Why would you need a different background color? conf/dlggeneralbase.ui (line 371) <https://git.reviewboard.kde.org/r/130219/#comment68936> Can you please not change the accelerators? conf/okular.kcfg (line 294) <https://git.reviewboard.kde.org/r/130219/#comment68935> That's unacceptable, what about people that use a color theme different than yours? - Albert Astals Cid On Aug. 9, 2017, 12:59 p.m., Albert Freeman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130219/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2017, 12:59 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > Enable background color to be changed from settings > > > Diffs > ----- > > conf/dlggeneralbase.ui cf4ebca0 > conf/okular.kcfg 69ea8cf6 > ui/pageview.cpp 3d935a2e > > Diff: https://git.reviewboard.kde.org/r/130219/diff/ > > > Testing > ------- > > > Thanks, > > Albert Freeman > >