rkflx added a comment.
Thanks for picking up old reviewboard requests. I like the feature in general, it is standard in a lot of applications today. But to make it easier to use, users should not relearn the UI they are already familiar with. This is what Dolphin currently provides vs. the patch: | F3903699: dolphin-tab-quit.png <https://phabricator.kde.org/F3903699> | F3903701: okular-tab-quit.png <https://phabricator.kde.org/F3903701> | | Besides the relearning aspect, I find the dialog in Dolphin preferable because of the following properties: - Explicit actions on the buttons instead of ambiguous Yes/No which requires reading of the explanation. - Slightly better wording ("you have...open in this window" vs. "you have tabs."). - Warning icon instead of information icon. - Standard do-not-ask-again message instead of custom message (also, "when closing more than one tab" does not correspond directly to the "quit" action the user initiated and thus might be confusing, as you cannot close e.g. 4 out of 5 tabs). - Third button with the correct action for those of us hitting [Ctrl] + [Q] while we meant [Ctrl] + [W]. - (Okular's dialog title is better, though.) Thus, I would prefer something akin to the Dolphin dialog being implemented in Okular. Lastly, Dolphin has a way to reset the warning status in the settings, is there any way to reset it in Okular too? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7714 To: aacid Cc: rkflx, #okular, aacid
