ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed.
Couple of smaller issues. Otherwise I didn't spot anything which looked very wrong to me, admittedly I don't know much about okular though. INLINE COMMENTS > document.cpp:3269 > + { > + for ( PixmapRequest *executingRequest : d->m_executingPixmapRequests > ) > + { Shouldn't that be using qAsConst? > document.cpp:3327 > + > + for ( DocumentObserver *o : observersPixmapCleared ) > + o->notifyContentsCleared( Okular::DocumentObserver::Pixmap ); qAsConst missing REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9328 To: aacid, ervin Cc: ervin, michaelweghorn, ngraham, #okular, gassaf, aacid