dileepsankhla added inline comments. INLINE COMMENTS
> tobiasdeiminger wrote in annots.cpp:182 > Poppler::TextAnnotation::setTextFont is brand new poppler API (actually not > yet merged). We still want to support builds with older poppler versions. So > setTextFont needs to be surrounded by some > > #ifdef HAVE_POPPLER_0_xy > #endif > > where 0_xy is the poppler release for which we assume the API to be released. > Maybe 0_67, to be optimistic. > > To detect poppler version at build time, add a check_cxx_source_compiles for > Poppler::TextAnnotation::setTextFont and define HAVE_POPPLER_0_67 accordingly > in generators/poppler/CMakeLists.txt. Also add a cmakedefine to > generators/poppler/CMakeLists.txt. You'll find existing examples for other > versions if you look at these files. 1. Do I need to do something like this in okular/generators/poppler/annots.cpp: #ifdef HAVE_POPPLER_0_67 ppl_txtann->setTextColor( okl_txtann->textColor() ); #endif //HAVE_POPPLER_0_67 2. I didn't get what to do in generators/poppler/CMakeLists.txt. May you provide me an example? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla, tobiasdeiminger Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel
