yurchor added inline comments.
INLINE COMMENTS
> document.cpp:652
> + }
> + else if( printElement.tagName() ==
> QLatin1String("printRange") )
> + {
Is it possible to keep the consistent formatting with other if's?
It seems that in other code it is "if ( condition )", but here it is "if(
condition )" (without space between "if" and "(".
> document.cpp:1245
> + // create printing node
> + if( m_printRangeOption != QPrinter::AllPages)
> + {
Same here.
> part.cpp:3241
> // Set the available Print Range
> + if(m_document->printFrom() == -1 || m_document->printTo() == -1)
> + {
Similar here.
> part.cpp:3275
> +
> + if( rangeOption == QPrinter::PageRange )
> + {
Same here.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D16285
To: ahmadosama, #okular
Cc: yurchor, broulik, ngraham, okular-devel, aacid
