aacid added a comment.
Maybe an enum is better than a bool so if in the future more scaling options are implemented we don't need to change the signature again? INLINE COMMENTS > fileprinter.h:82 > PageSelectPolicy pageSelectPolicy = > FilePrinter::ApplicationSelectsPages, > - const QString &pageRange = QString() ); > this is not binary compatible, we try not to break the binary compatibility of the okular public classes. Add another method (without the default values) and make this one call the new one. Same for all the functions you're adding new parameters to. Or you can try to convince me that maintainting binary compatibilty is not needed :D REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvogt, okular-devel, ngraham, darcyshen
