davidhurka created this revision. davidhurka added reviewers: Okular, VDG. Herald added a project: Okular. Herald added a subscriber: okular-devel. davidhurka requested review of this revision.
REVISION SUMMARY This adds a new submenu to the View menu, which contains the existing Change Colors options. There is an action to toggle Change Colors on and off, and an action group to choose the Change Colors mode. The menu is an KActionMenu, so it can be plugged into the toolbar for quicker access. The KActionMenu is checkable, so toggling Change Colors just means to click the toolbar button once. This //might// be useful as soon as someone implements a useful Change Colors mode. TEST PLAN - Look at menu in menubar, there should be View->Change Colors->... Then, plug the Change Colors menu into the toolbar: - Click it -> toggles - Open it -> choose another Change Colors mode Then, assign shortcuts - Shortcuts shouldn’t be removed after using them - Triggering the shortcut for e. g. Change Paper Color also can toggle Change Colors on and off REPOSITORY R223 Okular BRANCH create-change-colors-menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D21195 AFFECTED FILES conf/preferencesdialog.cpp conf/preferencesdialog.h part.cpp part.h ui/pageview.cpp ui/pageview.h To: davidhurka, #okular, #vdg Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
