davidhurka marked 4 inline comments as done.
davidhurka added inline comments.

INLINE COMMENTS

> aacid wrote in part.h:120
> the thing is, that's not true, calling openUrl is fine, it's what the okular 
> shell does, no?

Yes and yes. The shell has an URL that doesn’t need to be tolerantly parsed.

The purpose of openDocument(QUrl) is to be called by other applications, where 
the quality of the URL is not defined (only to be expected when Okular::Part is 
not used though the KPart interface), right?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21281

To: davidhurka, #okular
Cc: ognarb, jucato, aacid, okular-devel, fbampaloukas, joaonetto, tfella, 
ngraham, darcyshen

Reply via email to