ahmadsamir added a comment.
In D25684#572361 <https://phabricator.kde.org/D25684#572361>, @aacid wrote: > Please rebase your patch on current master, since it will fail to merge properly, i prefer you do the work and not me ^_^ FWIW, I always 'git pull --rebase' on the branch right before I 'arc land' :) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25684 To: ahmadsamir, aacid Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid