El divendres, 21 d’agost de 2020, a les 1:19:19 CEST, Albert Astals Cid va escriure: > Most of the guidelines suggest it so that you don't forget to add them when > adding a new line in the "block". > > What do you think? > > https://invent.kde.org/graphics/okular/-/merge_requests/248 > > We're going to need quite some changes to make it pass, so asking before > starting to do the work :D
We agreed on the Akademy Okular meeting that we will do this, *but* I'm going to postpone doing it after the 20.08.3 release. Rationale: * Making this change even if mechanical (clang-tidy does it) can cause potential regressions if something goes wrong, hence is something that needs to be applied in master only * If we apply it to master now, merging up from release/20.08 to master can cause master CI to stop compiling since it'd be requiring more things than release/20.08 CI Cheers, Albert > > Cheers, > Albert > > >
