[ 
https://issues.apache.org/jira/browse/OLIO-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shanti Subramanyam closed OLIO-89.
----------------------------------


> Remove unneceesary patch/diff files in fixture_replacement2
> -----------------------------------------------------------
>
>                 Key: OLIO-89
>                 URL: https://issues.apache.org/jira/browse/OLIO-89
>             Project: Olio
>          Issue Type: Improvement
>          Components: rails-app
>    Affects Versions: 0.1
>            Reporter: Shanti Subramanyam
>            Assignee: Shanti Subramanyam
>            Priority: Minor
>             Fix For: 0.2
>
>
> This plugin has several .diff and .patch files. If these files are not 
> required, remove them. This issue was raised during 0.1 review :
> >> sebb wrote:
> >> The binary olio file contains several .patch and .diff files. These
> >> > > don't seem correct for a binary file. What is their purpose?
> >> > >
> >> > >
> >> > >
> > >  These files are part of the 3rd party plugin fixture_replacement2. Since 
> > > we
> > > tend to include 3rd party code as is (for easier upgrade),  I think it 
> > > might
> > > be better to leave them as they are.
> But why are they in the binary rails jar, rather than in just the source jar?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to