John Sonnenschein writes:
> I've tried the normal channel with no bites, seems people don't like  
> doing CR ;)
> 
> Anyhow, could I get a code review/sanity check on 6733971 from someone ?
> 
> code at:
> http://cr.opensolaris.org/~error404/6733971/

Instead of introducing spaces -- which I think makes the code just a
little more obscure -- why not get rid of the superfluous parenthesis?

In other words, instead of this:

        @( $(LHEAD) $(LINT.c) $< $(LTAIL) )

just do this:

        @$(LHEAD) $(LINT.c) $< $(LTAIL)

That way, there's no question for future maintainers, and both forms
appear to be equivalent for ksh93.

Are all these subshells doing us any good?

-- 
James Carlson, Solaris Networking              <james.d.carlson at sun.com>
Sun Microsystems / 35 Network Drive        71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677

Reply via email to