>>>>> "Mark" == Mark J Nelson <Mark.J.Nelson at Sun.COM> writes:
Mark> 116/123: the $(CLEANCHUNKDIR) dependency seems like it might be a
Mark> little bit misplaced, in that it's part of the dependency chain of
Mark> rawchunks instead of $(ONCHUNKS). Seems like there could be a
Mark> race condition for a fast, parallel build, where something could
Mark> fire the actions on 142 (and therefore 136) before 123?
Mike> This is serial make (no .PARALLEL target). IMO it's not big enough
Mike> to be worth trying to parallelize.
Mark> I still think the dependencies should sort correctly, though. I
Mark> don't think there's a guarantee for which target will be built
Mark> first, is there?
I thought that dependencies were processed depth-first, left-to-right,
though I can't find anything in the documentation that specifically says
that.
If it's not something we can rely on, I think this is also an issue for
ON makefiles, like this bit from uts/Makefile:
install: all_h install_dirs $(PMTMO_FILE) $($(MACH)_ARCHITECTURES)
(The $($(MACH)_ARCHITECTURES) builds depend on the header file
generation that is done in "all_h".)
But the good news here is that your suggestion does simplify the
makefile quite a bit, and it makes this particular dependency question
go away.
Updated webrev is at http://cr.opensolaris.org/~kupfer/devref-chunks/.
Mike> For some reason fixup.pyc is no longer being created, so I removed
Mike> *.pyc from the "clean" target, too.
Mark> Permissions? It should be there, somewhere, I think.
That's what I thought, but it's not. The permissions are fine. Maybe
it's because it's invoked as "python fixup.py", not "fixup.py"?
mike
