Alan Coopersmith wrote:
> http://cr.opensolaris.org/~alanc/7016849/
Makefile:
- It would be useful to have rules that downloaded new ID files. You
could store the URLs in the makefile and have something like
pci.ids:
curl -s -o $@ $PCI_URL
and force regeneration with "gmake -B pci.ids".
- line 41: can you put a definition for GSED (or SED if you really want,
but either way, I don't see a point in using the Solaris version) in
shared-macros.mk and use it? Points for fixing all the other
components up.
- line 51: why use both basename and F?
- line 52: I'm confused by the use of the curly braces. Don't they need
to be paired? Or do the -e arguments simply concatenate? And if so,
why not just do it in the makefile?
- I'd suggest swiping the date from the ids files and stuff that into the
version, but since they're maintained independently, you'd need
separate packages, which doesn't seem worth the trouble.
*.p5m:
- We don't usually use the whole fmri stem in the manifest filename;
hwdata.p5m would be sufficient.
- line 43: is there any particular reason that this is group sys,
particularly when the files aren't?
Danek
_______________________________________________
on-ips-dev mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/on-ips-dev
