Oh, good to know Michael! Just as a small note, git push does not have to push directly into master. You can use "git push origin HEAD:refs/for/master" where "for" will make sure it goes into Gerrit.
I am glad you are unblocked though. thanks Jess On Wed May 16 20:00:12 2018, frank.obr...@amdocs.com wrote: > Jessica, > Thanks, git push never works for me as gerrit rejects pushes > directly to master. > However just fixed the issue using a google search that put me back > to page from last year - for some reason I lost my commit hook config > during an upgrade > > fixed > > https://wiki.onap.org/display/DW/questions/13599958/answers/33065267?flashId=361039830 > https://gerrit.onap.org/r/#/c/47941/1 > > Issue is a catch 22 - you need to tix the commit hook to see the > workaround to fix the commit hook > > obrienbiometrics:oom michaelobrien$ curl -kLo `git rev-parse --git- > dir`/hooks/commit-msg http://gerrit.onap.org/r/tools/hooks/commit-msg; > chmod +x `git rev-parse --git-dir`/hooks/commit-msg > % Total % Received % Xferd Average Speed Time Time Time > Current > Dload Upload Total Spent Left > Speed > 100 178 100 178 0 0 1032 0 --:--:-- --:--:-- --:-- > :-- 1034 > 100 4662 100 4662 0 0 9173 0 --:--:-- --:--:-- --:-- > :-- 9173 > obrienbiometrics:oom michaelobrien$ git review > remote: Processing changes: refs: 1, done > remote: ERROR: missing Change-Id in commit message footer > remote: > remote: Hint: To automatically insert Change-Id, install the > hook: > remote: gitdir=$(git rev-parse --git-dir); scp -p -P 29418 > michaelobr...@gerrit.onap.org:hooks/commit-msg ${gitdir}/hooks/ > remote: And then amend the commit: > remote: git commit --amend > remote: > To https://gerrit.onap.org/r/a/oom > ! [remote rejected] HEAD -> refs/publish/master (missing Change-Id in > commit message footer) > error: failed to push some refs to > 'https://michaelobr...@gerrit.onap.org/r/a/oom' > obrienbiometrics:oom michaelobrien$ git commit --amend > [master e997e98] log logstash replicaset to 3 > Date: Wed May 16 18:55:11 2018 -0400 > 1 file changed, 2 insertions(+), 1 deletion(-) > obrienbiometrics:oom michaelobrien$ git review > remote: Processing changes: new: 1, refs: 1, done > remote: > remote: New Changes: > remote: https://gerrit.onap.org/r/47941 log logstash > replicaset to 3 > remote: > To https://gerrit.onap.org/r/a/oom > * [new branch] HEAD -> refs/publish/master > Comment > > One of the critical issues is the fact that the logstash container is > saturated with 30 logs/sec on an idle onap - the VM in a cluster that > contains that pod will have 7 of it's 8 cores saturated - affecting > all other pods on that node - in a 3 node cluster that means up to > 30% of the system may have readiness issues (as Identified by Jun and > Shishir) then as they will be CPU starved on that particular node - > this is expected because I have not fine tuned the resource/scaling > config yet. > > > The fix is simple (because OOM has already configured a ReplicaSet for > all the pods - I just up the replicaCount from 1 to 3) so far and I > prototyped it on my AWS cluster - by pausing the CD job, retrofitting > the yaml and restarting ONAP - we go from 6.5 cores to an average of 1 > across 3 pods in 3 nodes even after 60 min. > Verified logs still get through to > <cluster_ip_containing_kibana_pod>:30253 - on my cluster > master3.onap.info:30253 > > See screencaps and testing results on the jira - in particular the > Grafana dashboard (thanks James M.) - the cpu load drops now across > the affected cluster node and we see normal random cpu traffic instead > of saturation on 1 of the 4 vms. > > > -----Original Message----- > From: onap-discuss-boun...@lists.onap.org [mailto:onap-discuss- > boun...@lists.onap.org] On Behalf Of Michael O'Brien via RT > Sent: Wednesday, May 16, 2018 7:36 PM > Cc: onap-discuss@lists.onap.org > Subject: Re: [onap-discuss] [ONAP Helpdesk #56089] [LF] Gerrit review > fails to push on jetty 404 looking for /tools/hooks/commit-msg > > Will try that - but my msg has no commit-id yet > > Tried updating an existing review - worked fine - may be an issue on > my part Also I see new reviews coming in from other developers - so > likely me only > > obrienbiometrics:logging-analytics michaelobrien$ git status On branch > master Your branch and 'origin/master' have diverged, and have 1 and 6 > different commits each, respectively. > (use "git pull" to merge the remote branch into yours) Changes to be > committed: > (use "git reset HEAD <file>..." to unstage) > > modified: deploy/cd.sh > > obrienbiometrics:logging-analytics michaelobrien$ git commit --amend > [master 6f718d2] cd.sh oom deployment script > Date: Mon May 14 20:25:45 2018 -0400 > 1 file changed, 365 insertions(+) > create mode 100755 deploy/cd.sh > obrienbiometrics:logging-analytics michaelobrien$ git review -R > Warning: Permanently added > '[gerrit.onap.org]:29418,[198.145.29.92]:29418' (RSA) to the list of > known hosts. > remote: Processing changes: updated: 1, refs: 1, done > remote: > remote: Updated Changes: > remote: https://gerrit.onap.org/r/47503 cd.sh oom deployment > script > remote: > To ssh://gerrit.onap.org:29418/logging-analytics > * [new branch] HEAD -> refs/publish/master > > > -----Original Message----- > From: Jessica Wagantall via RT [mailto:onap- > helpd...@rt.linuxfoundation.org] > Sent: Wednesday, May 16, 2018 7:17 PM > To: Michael O'Brien <frank.obr...@amdocs.com> > Cc: onap-discuss@lists.onap.org > Subject: [ONAP Helpdesk #56089] [LF] Gerrit review fails to push on > jetty 404 looking for /tools/hooks/commit-msg > > Michael, > > Are you able to push the code using git push? > > Thanks! > Jess > > > On Wed May 16 19:02:37 2018, frank.obr...@amdocs.com wrote: > > Team, > > Hi, having a new issue pushing code to gerrit - getting a 404 - > > where previously if there was a commit message format issue it would > > notify you of the cause - getting a 404 now. > > Pushing reviews a couple days ago had no issues. > > Is anyone else having issues pushing a new gerrit review > > Will amend "git review -R" and existing review to see if it is > > just > > for new commits > > > > Details on > > https://jira.onap.org/browse/LOG-376 > > > > > > obrienbiometrics:log-376b michaelobrien$ cd oom > > > > obrienbiometrics:oom michaelobrien$ git status > > > > On branch master > > > > Your branch is up-to-date with 'origin/master'. > > > > Changes to be committed: > > > > (use "git reset HEAD <file>..." to unstage) > > > > > > > > modified: kubernetes/log/charts/log-logstash/values.yaml > > > > > > > > obrienbiometrics:oom michaelobrien$ git commit -am "log logstash > > replicaset to 3" > > > > [master 8324970] log logstash replicaset to 3 > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > obrienbiometrics:oom michaelobrien$ git commit -s --amend > > > > [master 05509fc] log logstash replicaset to 3 > > > > Date: Wed May 16 18:55:11 2018 -0400 > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > obrienbiometrics:oom michaelobrien$ git review > > > > Problems encountered installing commit-msg hook > > > > The following command failed with exit code 104 > > > > "GET https://michaelobr...@gerrit.onap.org/tools/hooks/commit-msg"; > > > > ----------------------- > > > > <html> > > > > <head> > > > > <meta http-equiv="Content-Type" content="text/html;charset=ISO-8859- > > 1"/> > > > > <title>Error 404 </title> > > > > </head> > > > > <body> > > > > <h2>HTTP ERROR: 404</h2> > > > > <p>Problem accessing /tools/hooks/commit-msg. Reason: > > > > <pre> Not Found</pre></p> > > > > <hr /><i><small>Powered by Jetty://</small></i> > > > > </body> > > > > </html> > > > > > > > > ----------------------- > > * > > Co<https://jira.onap.org/secure/AddComment!default.jspa?id=22902> > > > > This message and the information contained herein is proprietary and > > confidential and subject to the Amdocs policy statement, > > > > you may review at https://www.amdocs.com/about/email-disclaimer > > <https://www.amdocs.com/about/email-disclaimer> > > > > This message and the information contained herein is proprietary and > confidential and subject to the Amdocs policy statement, > > you may review at https://www.amdocs.com/about/email-disclaimer > <https://www.amdocs.com/about/email-disclaimer> > > _______________________________________________ > onap-discuss mailing list > onap-discuss@lists.onap.org > https://lists.onap.org/mailman/listinfo/onap-discuss > This message and the information contained herein is proprietary and > confidential and subject to the Amdocs policy statement, > > you may review at https://www.amdocs.com/about/email-disclaimer > <https://www.amdocs.com/about/email-disclaimer> _______________________________________________ onap-discuss mailing list onap-discuss@lists.onap.org https://lists.onap.org/mailman/listinfo/onap-discuss
