++Zu Regards, Ajay ________________________________ From: onap-discuss@lists.onap.org <onap-discuss@lists.onap.org> on behalf of Ajay Deep Singh via lists.onap.org <ajay.deep.singh=est.t...@lists.onap.org> Sent: Wednesday, August 19, 2020 3:41 PM To: onap-...@lists.onap.org <onap-...@lists.onap.org>; onap-discuss@lists.onap.org <onap-discuss@lists.onap.org> Subject: Re: [onap-discuss] Regarding SDC-3090 (Error Updating VSP in a resource template for PNF) Looking for Help.
Hi Xue, Christophe, As it was discussed in weekly meeting please can you share more details on this JIRA : SDC-3090 (Error Updating VSP in a resource template for PNF). I find you Xue assigning JIRA to your Id, are you implementing changes for the support of PNF, VNF..? Otherwise please can you highlight on why there exist this limitation for PNF, VNF..? and how can we mitigate this limitation. Regards, Ajay ________________________________ From: onap-discuss@lists.onap.org <onap-discuss@lists.onap.org> on behalf of Ajay Deep Singh via lists.onap.org <ajay.deep.singh=est.t...@lists.onap.org> Sent: Saturday, August 8, 2020 2:20 PM To: onap-...@lists.onap.org <onap-...@lists.onap.org>; onap-discuss@lists.onap.org <onap-discuss@lists.onap.org> Subject: Re: [onap-discuss] Regarding SDC-3090 (Error Updating VSP in a resource template for PNF) Looking for Help. Hi SDC Team, All, Please have a check on below issue. Trying to confirm SDC behaviour for one usecase. Any pointers would be very much appreciated! Regards, Ajay ________________________________ From: Ajay Deep Singh <ajay.deep.si...@est.tech> Sent: Wednesday, August 5, 2020 5:10 PM To: onap-...@lists.onap.org <onap-...@lists.onap.org>; Closset, Christophe <christophe.clos...@intl.att.com> Cc: Sonsino, Ofir <ofir.sons...@intl.att.com>; Zu Qiang <zu.qi...@ericsson.com>; Shlosberg, Yuli <yuli.shlosb...@intl.att.com>; James Cuddy <james.cu...@est.tech>; Anderson Ribeiro <anderson.ribe...@est.tech>; Michael Morris <michael.mor...@est.tech>; ml6...@att.com <ml6...@att.com> Subject: Re: Regarding SDC-3090 (Error Updating VSP in a resource template for PNF) Looking for Help. Hi All, ++ onap-...@lists.onap.org<mailto:onap-...@lists.onap.org> Please have a look on below mail chain, looking for existing SDC behaviour on one of usecase, where encountering isssue details are mentioned in JIRA SDC-3090 (Error Updating VSP in a resource template for PNF). Any pointers would be very much appreciated! Regards, Ajay ________________________________ From: Closset, Christophe <christophe.clos...@intl.att.com> Sent: Wednesday, August 5, 2020 2:49 PM To: Ajay Deep Singh <ajay.deep.si...@est.tech>; onap-...@lists.onap.org <onap-...@lists.onap.org> Cc: Sonsino, Ofir <ofir.sons...@intl.att.com>; Zu Qiang <zu.qi...@ericsson.com>; Shlosberg, Yuli <yuli.shlosb...@intl.att.com>; James Cuddy <james.cu...@est.tech>; Anderson Ribeiro <anderson.ribe...@est.tech>; Michael Morris <michael.mor...@est.tech>; ml6...@att.com <ml6...@att.com> Subject: Re: Regarding SDC-3090 (Error Updating VSP in a resource template for PNF) Looking for Help. Hi ajay I m off this week, pls use sdc mailing list so that all team members can have a look Le 5 août 2020 10:43, Ajay Deep Singh <ajay.deep.si...@est.tech> a écrit : Hi Christophe, Ofir, I am looking for help on one of SDC issue request you to please put this Bug : SDC-3090 (Error Updating VSP in a resource template for PNF) in agenda for next week SDC weekly meeting so that we can discuss more on it. Details for bug are described in JIRA SDC-3090, and analysis as described in below mail, need to confirm existing SDC behaviour on one of usecase. Regards, Ajay ________________________________ From: Ajay Deep Singh <ajay.deep.si...@est.tech> Sent: Friday, July 31, 2020 2:02 PM To: Shlosberg, Yuli <yuli.shlosb...@intl.att.com>; christophe.clos...@intl.att.com <christophe.clos...@intl.att.com>; ml6...@att.com <ml6...@att.com>; Sonsino, Ofir <ofir.sons...@intl.att.com>; Nachmias, Lior <lior.nachm...@intl.att.com> Cc: James Cuddy <james.cu...@est.tech>; Anderson Ribeiro <anderson.ribe...@est.tech>; Michael Morris <michael.mor...@est.tech> Subject: Re: Regarding SDC-3090 (Error Updating VSP in a resource template for PNF) Looking for Help. Hi Yuli, we have debuged it further and can find: if we have different resource name in pnf_main_descriptor.yaml file present inside CSAR package then use case works without issue. Please can you or any in mail chain confirm if this should be required condition for input on updating VSP Package with new CSAR patch..?? I am attaching CSAR Packages for reference. File format example: sample-pnf-1.0.1-SNAPSHOT_1.csar content of pnf_main_descriptor.yaml : topology_template: node_templates: myPnf: type: tosca.nodes.nfv.PNF properties: descriptor_id: b1bb0ce7-ebca-4fa7-95ed-4840d70a2233 function_description: Acme PNF provider: Acme version: 1.0 descriptor_invariant_id: 1111-2222-ccaa-bbdd name: Acme PNF pnfExtCp_1: type: tosca.nodes.nfv.PnfExtCp properties: trunk_mode: false layer_protocols: [ ipv4 ] role: leaf description: External connection point to access Acme myPnf requirements: - dependency: myPnf ***************************************************** sample-pnf-1.0.1-SNAPSHOT_2.csar content of pnf_main_descriptor.yaml : topology_template: node_templates: myPnf: type: tosca.nodes.nfv.PNF properties: descriptor_id: b1bb0ce7-ebca-4fa7-95ed-4840d70a2233 function_description: Acme PNF provider: Acme version: 1.0 descriptor_invariant_id: 1111-2222-ccaa-bbdd name: Acme PNF pnfExtCp_2: type: tosca.nodes.nfv.PnfExtCp properties: trunk_mode: false layer_protocols: [ ipv4 ] role: leaf description: External connection point to access Acme myPnf requirements: - dependency: myPnf Regards, Ajay ________________________________ From: Ajay Deep Singh <ajay.deep.si...@est.tech> Sent: Thursday, July 30, 2020 9:56 AM To: Shlosberg, Yuli <yuli.shlosb...@intl.att.com>; ml6...@att.com <ml6...@att.com>; christophe.clos...@intl.att.com <christophe.clos...@intl.att.com> Cc: James Cuddy <james.cu...@est.tech>; Nachmias, Lior <lior.nachm...@intl.att.com>; Sonsino, Ofir <ofir.sons...@intl.att.com> Subject: Re: Regarding SDC-3090 (Error Updating VSP in a resource template for PNF) Looking for Help. Hi Yuli, Sorry for late follow up on this issue. I carried out debugging and can find ComponentInstance is created making use of Resource instance on which most values for attributes are null, Resource Instance is framed by fetching getLatestCertifiedNodeTypeByToscaResourceName(..) probably form Db, not sure if Resource Instance should have Null values or not. I wourld request if you can share convenient time as per your time zone today, I can schedule meeting where we can meet and build some understaing to reslove this issue..? Resource Instance: Resource(derivedFrom=[org.openecomp.resource.cp.nodes.network.Port], derivedList=[org.openecomp.resource.cp.v2.extCP, org.openecomp.resource.cp.nodes.network.Port, tosca.nodes.network.Port, tosca.nodes.Root], derivedFromMapOfIdToName={517edee6-2100-43d6-b55d-25e6876a29dc=org.openecomp.resource.cp.v2.extCP, 5cf3bf9e-8cc4-4d43-a4aa-99f15145adad=org.openecomp.resource.cp.nodes.network.Port, 6c804eda-5268-455c-be95-949443f25aa1=tosca.nodes.network.Port, 2921822b-f9c2-47cb-8576-6599262601f5=tosca.nodes.Root}, attributes= [PropertyDefinition [ PropertyDataDefinition(uniqueId=attribute.2921822b-f9c2-47cb-8576-6599262601f5.tosca_name, type=string, required=false, definition=false, defaultValue=null, description=null, schema=null, password=false, name=tosca_name, value=null, label=null, hidden=false, immutable=false, inputPath=null, status=null, inputId=null, instanceUniqueId=null, propertyId=null, parentPropertyType=null, subPropertyInputPath=null, annotations=null, parentUniqueId=517edee6-2100-43d6-b55d-25e6876a29dc, getInputValues=null, isDeclaredListInput=false, getPolicyValues=null, propertyConstraints=null), name=tosca_name, constraints=null]], PropertyDefinition [ PropertyDataDefinition(uniqueId=attribute.2921822b-f9c2-47cb-8576-6599262601f5.state, type=string, required=false, definition=false, defaultValue=null, description=null, schema=null, password=false, name=state, value=null, label=null, hidden=false, immutable=false, inputPath=null, status=null, inputId=null, instanceUniqueId=null, propertyId=null, parentPropertyType=null, subPropertyInputPath=null, annotations=null, parentUniqueId=517edee6-2100-43d6-b55d-25e6876a29dc, getInputValues=null, isDeclaredListInput=false, getPolicyValues=null, propertyConstraints=null), name=state, constraints=null]], PropertyDefinition [ PropertyDataDefinition(uniqueId=attribute.2921822b-f9c2-47cb-8576-6599262601f5.tosca_id, type=string, required=false, definition=false, defaultValue=null, description=null, schema=null, password=false, name=tosca_id, value=null, label=null, hidden=false, immutable=false, inputPath=null, status=null, inputId=null, instanceUniqueId=null, propertyId=null, parentPropertyType=null, subPropertyInputPath=null, annotations=null, parentUniqueId=517edee6-2100-43d6-b55d-25e6876a29dc, getInputValues=null, isDeclaredListInput=false, getPolicyValues=null, propertyConstraints=null), name=tosca_id, constraints=null]]], toscaVersion=null) ComponentInstanceDataDefinition [icon=null, uniqueId=null, name=null, normalizedName=null, componentUid=517edee6-2100-43d6-b55d-25e6876a29dc, creationTime=null, modificationTime=null, description=null, posX=null, posY=null, propertyValueCounter=1, attributeValueCounter=1, inputValueCounter=1, originType=null, customizationUUID=null, componentName=null, componentVersion=null, toscaComponentName=null, directives =] Regards, Ajay ________________________________ From: Shlosberg, Yuli <yuli.shlosb...@intl.att.com> Sent: Thursday, July 2, 2020 9:55 AM To: Ajay Deep Singh <ajay.deep.si...@est.tech>; ml6...@att.com <ml6...@att.com>; Sonsino, Ofir <ofir.sons...@intl.att.com> Cc: James Cuddy <james.cu...@est.tech>; Nachmias, Lior <lior.nachm...@intl.att.com> Subject: RE: Regarding SDC-3090 (Error Updating VSP in a resource template for PNF) Looking for Help. Hi Ajay, I'm good thank you, sorry for late response I was OOO in last few days. Regarding you question, it seems that <instance 1> has many null attributes (e.g. uniqueId, normalizedName ) and I think that the main problem is some ware in begin of this flow. Try to debug it again and find how you get a < componentInstanceTMap > that include instance with nulls. BR, Yuli From: Ajay Deep Singh <ajay.deep.si...@est.tech> Sent: Wednesday, July 1, 2020 8:25 PM To: Shlosberg, Yuli <yuli.shlosb...@intl.att.com>; ml6...@att.com; Sonsino, Ofir <ofir.sons...@intl.att.com> Cc: James Cuddy <james.cu...@est.tech> Subject: Re: Regarding SDC-3090 (Error Updating VSP in a resource template for PNF) Looking for Help. Hi All, Any one had a chance to go throught below mail...? Regards, Ajay ________________________________ From: Ajay Deep Singh Sent: Monday, June 29, 2020 4:45 PM To: ys9...@att.com<mailto:ys9...@att.com> <ys9...@att.com<mailto:ys9...@att.com>>; ml6...@att.com<mailto:ml6...@att.com> <ml6...@att.com<mailto:ml6...@att.com>>; ofir.sons...@intl.att.com<mailto:ofir.sons...@intl.att.com> <ofir.sons...@intl.att.com<mailto:ofir.sons...@intl.att.com>> Cc: James Cuddy <james.cu...@est.tech<mailto:james.cu...@est.tech>> Subject: Regarding SDC-3090 (Error Updating VSP in a resource template for PNF) Looking for Help. Hi Yuli, All, Hope you are doing good. Regarding JIRA : SDC-3090<https://urldefense.proofpoint.com/v2/url?u=https-3A__jira.onap.org_browse_SDC-2D3090&d=DwMFAw&c=LFYZ-o9_HUMeMTSQicvjIg&r=pSBxzgxpdMj554rpWz7GtQ&m=fxgXySOp4LeInmbFLa88ZoW7pAGDOk9mja1HtY23uhQ&s=8SzMKlyXg61b4DzBthGxe3_878AfiUgiZlwrf5XDOrs&e=> thought of checking with you finding you as committer for SDC-2724<https://urldefense.proofpoint.com/v2/url?u=https-3A__jira.onap.org_browse_SDC-2D2724&d=DwMFAw&c=LFYZ-o9_HUMeMTSQicvjIg&r=pSBxzgxpdMj554rpWz7GtQ&m=fxgXySOp4LeInmbFLa88ZoW7pAGDOk9mja1HtY23uhQ&s=3cVt1kdAFJKb_NmBrqrfB_3CJiB5lewHa78TUxWcDCg&e=> might help in quckly resloving issue. While trying to update a VSP of a PNF Resource a 500 Server Error is encountered, see screenshot in JIRA attached. Steps : 1. Onboarding package: onboarding-package-1.csar 2. Package to update with: onboarding-package-2.csar On debugging can find there is comparasion made between two instance of ComponentInstanceDataDefinition probably new and Odl related to VSP package. Instance 1 : {ComponentInstance@15757} "ComponentInstanceDataDefinition [icon=network, uniqueId=null, name=pnfExtCp_1, normalizedName=null, componentUid=dceb80be-95e4-4d21-b2c5-c4f557fcccec, creationTime=null, modificationTime=null, description=null, posX=null, posY=null, propertyValueCounter=1, attributeValueCounter=1, inputValueCounter=1, originType=null, customizationUUID=null, componentName=null, componentVersion=null, toscaComponentName=null, directives =]" -> {Resource@15758} "Resource(derivedFrom=[org.openecomp.resource.cp.nodes.network.Port], derivedList=[org.openecomp.resource.cp.v2.extCP, org.openecomp.resource.cp.nodes.network.Port, tosca.nodes.network.Port, tosca.nodes.Root], derivedFromMapOfIdToName={dceb80be-95e4-4d21-b2c5-c4f557fcccec=org.openecomp.resource.cp.v2.extCP, 7f98971d-2bb3-445f-af3a-c9ffb9a7fcb8=org.openecomp.resource.cp.nodes.network.Port, fc2a8de1-f0be-4ede-b7ce-b3e4edb49c7f=tosca.nodes.network.Port, e0835ece-c04b-44d6-bebd-ace92cafa155=tosca.nodes.Root}, attributes=[PropertyDefinition [ PropertyDataDefinition(uniqueId=attribute.e0835ece-c04b-44d6-bebd-ace92cafa155.tosca_name, type=string, required=false, definition=false, defaultValue=null, description=null, schema=null, password=false, name=tosca_name, value=null, label=null, hidden=false, immutable=false, inputPath=null, status=null, inputId=null, instanceUniqueId=null, propertyId=null, parentPropertyType=null, subPropertyInputPath=null, annotations=null, parentUniqueId=dceb80be-95e4" Instance 2 : {ComponentInstance@15759} "ComponentInstanceDataDefinition [icon=network, uniqueId=109e6142-c4b4-45b9-ad3c-ee0dd4ba8580.dceb80be-95e4-4d21-b2c5-c4f557fcccec.pnfextcp_1, name=pnfExtCp_1, normalizedName=pnfextcp_1, componentUid=dceb80be-95e4-4d21-b2c5-c4f557fcccec, creationTime=1593439153060, modificationTime=1593439153116, description=null, posX=489.5, posY=339.5, propertyValueCounter=1, attributeValueCounter=null, inputValueCounter=null, originType=CP, customizationUUID=3f4e16fc-e289-4c22-988d-2a47057dcbc6, componentName=ExtCP2, componentVersion=1.0, toscaComponentName=org.openecomp.resource.cp.v2.extCP, directives =]" -> {Resource@15758} "Resource(derivedFrom=[org.openecomp.resource.cp.nodes.network.Port], derivedList=[org.openecomp.resource.cp.v2.extCP, org.openecomp.resource.cp.nodes.network.Port, tosca.nodes.network.Port, tosca.nodes.Root], derivedFromMapOfIdToName={dceb80be-95e4-4d21-b2c5-c4f557fcccec=org.openecomp.resource.cp.v2.extCP, 7f98971d-2bb3-445f-af3a-c9ffb9a7fcb8=org.openecomp.resource.cp.nodes.network.Port, fc2a8de1-f0be-4ede-b7ce-b3e4edb49c7f=tosca.nodes.network.Port, e0835ece-c04b-44d6-bebd-ace92cafa155=tosca.nodes.Root}, attributes=[PropertyDefinition [ PropertyDataDefinition(uniqueId=attribute.e0835ece-c04b-44d6-bebd-ace92cafa155.tosca_name, type=string, required=false, definition=false, defaultValue=null, description=null, schema=null, password=false, name=tosca_name, value=null, label=null, hidden=false, immutable=false, inputPath=null, status=null, inputId=null, instanceUniqueId=null, propertyId=null, parentPropertyType=null, subPropertyInputPath=null, annotations=null, parentUniqueId=dceb80be-95e4" In Class : NodeTemplateOperation >> in below method >> I see one operation is redundant and executed twice and fails on validateInstanceNames Method on >>> at CommonUtility.addRecordToLog(log, LogLevelEnum.DEBUG, "Component >>> instance with the name {} already exsists. Cannot add component instance. >>> ", instance.getName()); Above is the content of Map: componentInstanceTMap hold 2 instances. As the Name field has same Name for both Instance it fails is there a problem with creation of ComponentInstanceDataDefinition ..? Or should the Name check should not happen.?? Please can you guide some details on it. Regards, Ajay public <T extends Component> Map<String, ComponentInstanceDataDefinition> associateComponentInstancesToComponent( Component containerComponent, Map<ComponentInstance, T> componentInstanceTMap, GraphVertex containerVertex, boolean allowDeleted, boolean isUpdateCsar) { String containerId = containerComponent.getUniqueId(); Map<String, ComponentInstanceDataDefinition> instancesJsonData; Either<GraphVertex, JanusGraphOperationStatus> updateElement = null; if (!validateInstanceNames(componentInstanceTMap)) { throw new StorageException(StorageOperationStatus.INCONSISTENCY); } if (!validateInstanceNames(componentInstanceTMap)) { throw new StorageException(StorageOperationStatus.INCONSISTENCY); } if (!allowDeleted) { if (!validateDeletedResources(componentInstanceTMap)) { throw new StorageException(StorageOperationStatus.INCONSISTENCY); } } -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#21943): https://lists.onap.org/g/onap-discuss/message/21943 Mute This Topic: https://lists.onap.org/mt/76110837/21656 Group Owner: onap-discuss+ow...@lists.onap.org Unsubscribe: https://lists.onap.org/g/onap-discuss/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
