Hello,

Rick McGuire wrote:
> Rainer, please open a Patch tracker item for your changes an submit an
> SVN generated DIFF as the patch.
>
>   
OK, before I do this I would like to check which of the casts are really 
necessary and which can be omitted.
Unfortunately I never did a "SVN generated DIFF" before as I only use 
cvs... :-((
Is there a quick head up on how to do this ?

> As for the trap, I really can't recommend anything more that "debug
> it".  That's a fairly simple call, I can't see why that would trap
> like that.  Use the deugger to look at what's getting returned from
> RexxGetVersionInformation() to see if that information looks good.
> The only other thing I might suggest is possibly changing the printf()
> call to
>
> fprintf(stderr, "%s", ptr);
>
> But that's just a blind guess.
>   
I know... but I was exited that the IBM ifix did allow me to (at least) 
compile the code... so I had to share :-))
> Rick
>
>   
>> 2. Added a header for AIX (directely, not via the configure script for now)
>>
>> diff -r -c
>> ooRexx-4.0.0-TRUNK-ORIG/rexxapi/common/platform/unix/SysCSStream.cpp
>> ooRexx-4.0.0-TRUNK/rexxapi/common/platform/unix/SysCSStream.cpp
>> ***
>> ooRexx-4.0.0-TRUNK-ORIG/rexxapi/common/platform/unix/SysCSStream.cpp<------>2008-10-21
>> 08:00:50.000000000 +0200
>> ---
>> ooRexx-4.0.0-TRUNK/rexxapi/common/platform/unix/SysCSStream.cpp<--->2008-10-21
>> 19:25:37.000000000 +0200
>> ***************
>> *** 51,57 ****
>> --- 51,62 ----
>>  #include <sys/ioctl.h>
>>  #include <netdb.h>
>>  #if !defined(__OpenBSD__)
>> + #ifndef _AIX
>>  #include <byteswap.h>
>> + #endif
>> + #ifdef _AIX
>> + #include <strings.h>
>> + #endif
>>  #endif
>>  #include <errno.h>
>>  #include "SysCSStream.hpp"
>> ..
>>     

Should I try to put this in the autoconf or should I use the _AIX for 
the moment ??
>> 3. commented out some pieces which have bot been updated in rexxutil.cpp
>>
>> diff -r -c
>> ooRexx-4.0.0-TRUNK-ORIG/extensions/rexxutil/platform/unix/rexxutil.cpp
>> ooRexx-4.0.0-TRUNK/extensions/rexxutil/platform/unix/rexxutil.cpp
>> ***
>> ooRexx-4.0.0-TRUNK-ORIG/extensions/rexxutil/platform/unix/rexxutil.cpp<---->2008-10-21
>> 08:01:34.000000000 +0200
>> ---
>> ooRexx-4.0.0-TRUNK/extensions/rexxutil/platform/unix/rexxutil.cpp<->2008-10-21
>> 19:39:06.000000000 +0200
>> ***************
>> *** 1151,1157 ****
>>   if (options&NAME_ONLY)               /* name only?                 */
>>     strcpy(ldp->Temp, ldp->truefile);  /* just copy it over          */
>>   else {
>> ! #ifdef AIX
>>     timestamp = localtime_r(&(finfo->st_mtime),&stTimestamp); /* get the
>> time info */
>>  #else
>>     timestamp = localtime(&(finfo->st_mtime));/* get the time info   */
>> --- 1151,1157 ----
>>   if (options&NAME_ONLY)               /* name only?                 */
>>     strcpy(ldp->Temp, ldp->truefile);  /* just copy it over          */
>>   else {
>> ! #ifdef TAMMER_AIX
>>     timestamp = localtime_r(&(finfo->st_mtime),&stTimestamp); /* get the
>> time info */
>>  #else
>>     timestamp = localtime(&(finfo->st_mtime));/* get the time info   */
>> ***************
>> *** 3603,3609 ****
>>  }
>> ..
>> ..
>> ! #ifdef AIX
>>  /*************************************************************************
>>  * Function:  SysAddFuncPkg                                               *
>>  *                                                                        *
>> --- 3603,3609 ----
>>  }
>> ..
>> ..
>> ! #ifdef TAMEMR_AIX
>>  /*************************************************************************
>>  * Function:  SysAddFuncPkg                                               *
>>  *                                                                        *
>> ***************
>> *** 5183,5189 ****
>>     REXX_CLASSIC_ROUTINE(SysClearRexxMacroSpace, SysClearRexxMacroSpace),
>>     REXX_CLASSIC_ROUTINE(SysLoadRexxMacroSpace,  SysLoadRexxMacroSpace),
>>     REXX_CLASSIC_ROUTINE(SysSaveRexxMacroSpace,  SysSaveRexxMacroSpace),
>> ! #if defined(AIX)
>>     REXX_CLASSIC_ROUTINE(SysAddFuncPkg,          SysAddFuncPkg),
>>     REXX_CLASSIC_ROUTINE(SysAddCmdPkg,           SysAddCmdPkg),
>>     REXX_CLASSIC_ROUTINE(SysDropFuncPkg,         SysDropFuncPkg),
>> --- 5183,5189 ----
>>     REXX_CLASSIC_ROUTINE(SysClearRexxMacroSpace, SysClearRexxMacroSpace),
>>     REXX_CLASSIC_ROUTINE(SysLoadRexxMacroSpace,  SysLoadRexxMacroSpace),
>>     REXX_CLASSIC_ROUTINE(SysSaveRexxMacroSpace,  SysSaveRexxMacroSpace),
>> ! #if defined(TAMMER_AIX)
>>     REXX_CLASSIC_ROUTINE(SysAddFuncPkg,          SysAddFuncPkg),
>>     REXX_CLASSIC_ROUTINE(SysAddCmdPkg,           SysAddCmdPkg),
>>     REXX_CLASSIC_ROUTINE(SysDropFuncPkg,         SysDropFuncPkg),
>>
>> Are this utility functions no longer needed ??
>> What is the replacement for this functions ??
>>
>>     

Is there a quick explanation why this functionality is abandoned ??
Do we need to get this functions working on AIX or are they no longer 
needed ??

Bye
  Rainer

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Oorexx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/oorexx-devel

Reply via email to