Hi Rainer,

On Tue, Dec 30, 2008 at 5:02 AM, Rainer Tammer <tam...@tammer.net> wrote:

> Index: interpreter/runtime/Numerics.cpp
> ===================================================================
> --- interpreter/runtime/Numerics.cpp    (revision 3828)
> +++ interpreter/runtime/Numerics.cpp    (working copy)
> @@ -50,6 +50,9 @@
>  #include <limits.h>
>
>  #ifdef __REXX64__
> +#ifndef __INT64_C
> +#  define __INT64_C(c)  c ## L
> +#endif
>  const wholenumber_t Numerics::MAX_WHOLENUMBER =
> __INT64_C(999999999999999999);
>  const wholenumber_t Numerics::MIN_WHOLENUMBER =
> __INT64_C(-999999999999999999);
>  const wholenumber_t Numerics::MAX_EXPONENT = __INT64_C(999999999999999999);
> Index: api/platform/unix/rexxapitypes.h
> ===================================================================
> --- api/platform/unix/rexxapitypes.h    (revision 3828)
> +++ api/platform/unix/rexxapitypes.h    (working copy)
> @@ -48,7 +48,8 @@
>  #include <limits.h>
>  #include <pthread.h>
>
> -#if __WORDSIZE == 64
> +// AIX does not define __WORDSIZE, use __64BIT__ instead
> +#if __WORDSIZE == 64 || defined(__64BIT__)
>  #define __REXX64__
>  #else
>  #undef __REXX64__
>
> Any comments ?

If __WORDSIZE and __INT64_C are not defined on AIX, those 2 changes
seem okay to me.  We'll see what Rick thinks.

> I would like to see a small change to rexx -v:

I would also like to see some type of change here.  On 64-bit windows,
32-bit binaries also run.  I'd like to be able to tell from the
command line which binary, 32-bit or 64-bit, was getting invoked.

> Proposed version:
>
> Open Object Rexx Version 4.0.0
> Build date: Dec 30 2008
> Bit mode: 64      <- see here (or 32)
> Copyright (c) IBM Corporation 1995, 2004.
> Copyright (c) RexxLA 2005-2008.
> All Rights Reserved.
> This program and the accompanying materials
> are made available under the terms of the Common Public License v1.0
> which accompanies this distribution.
> http://www.oorexx.org/license.html
> Syntax is "rexx [-v] filename [arguments]"
> or        "rexx [-e] program_string [arguments]".

I know that part of that format is dictated by the standard, but not
how much.  Again, Rick is the expert.  I personally would rather see:

Open Object Rexx Version 4.0.0  (64-bit)
Build date: Dec 30 2008
Copyright (c) IBM Corporation 1995, 2004.
Copyright (c) RexxLA 2005-2008.

But, I'm not sure if the above fits the standard.  Below would be my
second pick:

Open Object Rexx Version 4.0.0
Build date: Dec 30 2008  (64-bit)
Copyright (c) IBM Corporation 1995, 2004.
Copyright (c) RexxLA 2005-2008.

--
Mark Miesfeld

------------------------------------------------------------------------------
_______________________________________________
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel

Reply via email to