I'm walking through the warnings which the CLANG compiler on Darwin issues
when compiling our latest 5.0 trunk
One of the warnings is
LocalRegistrationManager.cpp:359:14: warning:
case value not in enumerated type 'ErrorCode' [-Wswitch]
case CALLBACK_NOT_FOUND:
case DROP_NOT_AUTHORIZED:
The respective enum is defined in ServiceException.hpp
typedef enum
{
NO_ERROR_CODE,
MEMORY_ERROR,
SERVER_FAILURE,
API_FAILURE,
MACRO_SOURCE_NOT_FOUND,
MACRO_SOURCE_READ_ERROR,
MACRO_LOAD_REXX,
MACRO_TRANSLATION_ERROR,
MACROSPACE_FILE_READ_ERROR,
FILE_CREATION_ERROR,
MACROSPACE_VERSION_ERROR,
MACROSPACE_SIGNATURE_ERROR,
FILE_READ_ERROR,
FILE_WRITE_ERROR,
INVALID_QUEUE_NAME,
BAD_FIFO_LIFO,
BAD_WAIT_FLAG,
} ErrorCode;
I can see that
Local*Queue*Manager::processServiceException is covering errors
INVALID_QUEUE_NAME
BAD_FIFO_LIFO
BAD_WAIT_FLAG
Local*MacroSpace*Manager::processServiceException is covering
MACRO_SOURCE_NOT_FOUND
MACRO_TRANSLATION_ERROR
MACRO_SOURCE_READ_ERROR
FILE_CREATION_ERROR
MACROSPACE_FILE_READ_ERROR
FILE_READ_ERROR
FILE_WRITE_ERROR
MACROSPACE_VERSION_ERROR
MACROSPACE_SIGNATURE_ERROR
MACRO_DOES_NOT_EXIST
MACRO_LOAD_REXX
which most probably means that Local*Registration*
Manager::processServiceException
should be covering
MEMORY_ERROR
SERVER_FAILURE
API_FAILURE
Q: If so, which error codes (presumably from rexxapidefs.h) should they be
mapped to?
Q: What about LocalRegistrationManager::mapReturnResult? I assume this
will need to be chaged to a mapping similar to the one above.
Thanks!!!!!
RexxReturnCode LocalQueueManager::processServiceException(ServiceException
*e)
{
switch (e->getErrorCode())
{
case INVALID_QUEUE_NAME:
return RXQUEUE_BADQNAME;
case BAD_FIFO_LIFO:
return RXQUEUE_PRIORITY;
case BAD_WAIT_FLAG:
return RXQUEUE_BADWAITFLAG;
default:
return RXQUEUE_MEMFAIL;
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel
