> Am 19.02.2021 um 19:29 schrieb Rick McGuire <object.r...@gmail.com>:
>
>
>
> On Fri, Feb 19, 2021 at 1:19 PM P.O. Jonsson <oor...@jonases.se
> <mailto:oor...@jonases.se>> wrote:
> Hi René,
>
> During the build process rexxtry.rex is moved (not copied) from /samples to
> /bin, so despite being a samples it resides in the directory where the
> executables are. So it beats me how you can test rexx itself but not rexxtry
> when they reside in the same place?
>
> That said: the only test I have found related to rexxtry is in
> Package.testGroup, and it is merely a check that rexxtry can be found,
> nothing more afaik. Why not move this single test case out of
> Package.testGroup and make it a test of its own? Maybe more meaningful tests
> could be made since it is such a vital sample/program?
>
> This test belongs exactly where it is because is is a test of the
> functionality of the Package class, not of rexxtry itself.
>
> Rick
OK, I guess that settles it then.
On the subject of testing: I am getting large numbers of failing tests on
Windows, can you or Erich indicate what I am missing in my setup?
I have tried to follow the Wiki and I am using the latest downloaded 64-bit Win
installer (since I am having problems with Microsoft visual studio)
C:\Users\po\workspace>"C:\Program Files (x86)\Microsoft Visual
Studio\2017\Community\VC\Auxiliary\Build\vcvarsall.bat" amd64
**********************************************************************
** Visual Studio 2017 Developer Command Prompt v15.9.33
** Copyright (c) 2017 Microsoft Corporation
**********************************************************************
\Microsoft was unexpected at this time.
I cannot figure out what is wrong in this call?
Here the test cases that are failing on Windows
[failure] 20210219 19:29:21.712000
svn: r12094 Change date: 2020-06-20 21:36:30 +0200
Test: TEST_COMMAND_NOT_EXISTS
Class: ADDRESS.testGroup
File: ...\ooRexx\base\keyword\ADDRESS.testGroup
Line: 204
Failed: assertTrue
Expected: 1
Actual: 0
Message: tracker bug #1490 Windows Command doesn't raise FAILURE
[failure] 20210219 19:29:23.134000
svn: r12094 Change date: 2020-06-20 21:36:30 +0200
Test: TEST_PATH_COMMAND
Class: ADDRESS.testGroup
File: ...\ooRexx\base\keyword\ADDRESS.testGroup
Line: 235
Failed: assertSame
Expected: 1
Actual: 0
Message: tracker bug #1710 ADDRESS 'PATH' doesn't just search PATH
[failure] 20210219 19:29:32.775000
svn: r11759 Change date: 2019-02-15 00:19:21 +0100
Test: TEST_SAVE_EMPTY
Class: Macrospace.testGroup
File: ...\ooRexx\base\rexxutil\Macrospace.testGroup
Line: 344
Failed: assertEquals
Expected: 5
Actual: 0
Message: tracker bug #....
[failure] 20210219 19:29:32.775000
svn: r11759 Change date: 2019-02-15 00:19:21 +0100
Test: TEST_SAVE_FILE_NULL
Class: Macrospace.testGroup
File: ...\ooRexx\base\rexxutil\Macrospace.testGroup
Line: 333
Failed: assertEquals
Expected: 5
Actual: 0
Message: tracker bug #....
[failure] 20210219 19:29:46.431000
svn: r12136 Change date: 2020-12-06 19:41:25 +0100
Test: TEST_VOLUME_SPECIFICATIONS
Class: SYSDRIVE.TESTGROUP
File: ...\ooRexx\base\rexxutil\platform\windows\SysDrive.testGroup
Line: 103
Failed: assertNotSame
Expected: [] \== []
Actual: [] == []
Message: SysVolumeLabel c
[failure] 20210219 19:29:52.821000
svn: r11522 Change date: 2018-11-22 01:34:56 +0100
Test: TESTALLUSERSSTARTUP
Class: SpecialFolders.testgroup
File: ...\ooRexx\extensions\platform\windows\ole\SpecialFolders.testGroup
Line: 443
Failed: assertTrue
Expected: 1
Actual: 0
[failure] 20210219 19:29:52.900000
svn: r11522 Change date: 2018-11-22 01:34:56 +0100
Test: TESTAPPLICATIONDATA
Class: SpecialFolders.testgroup
File: ...\ooRexx\extensions\platform\windows\ole\SpecialFolders.testGroup
Line: 482
Failed: assertTrue
Expected: 1
Actual: 0
[failure] 20210219 19:29:53.071000
svn: r11522 Change date: 2018-11-22 01:34:56 +0100
Test: TESTFAVORITES
Class: SpecialFolders.testgroup
File: ...\ooRexx\extensions\platform\windows\ole\SpecialFolders.testGroup
Line: 171
Failed: assertTrue
Expected: 1
Actual: 0
[failure] 20210219 19:29:53.931000
svn: r11522 Change date: 2018-11-22 01:34:56 +0100
Test: TESTLOCALSETTINGSAPPLICATIONDATA
Class: SpecialFolders.testgroup
File: ...\ooRexx\extensions\platform\windows\ole\SpecialFolders.testGroup
Line: 523
Failed: assertTrue
Expected: 1
Actual: 0
[failure] 20210219 19:29:53.962000
svn: r11522 Change date: 2018-11-22 01:34:56 +0100
Test: TESTLOCALSETTINGSTEMPORARYINTERNETFILES
Class: SpecialFolders.testgroup
File: ...\ooRexx\extensions\platform\windows\ole\SpecialFolders.testGroup
Line: 559
Failed: assertTrue
Expected: 1
Actual: 0
[failure] 20210219 19:29:53.978000
svn: r11522 Change date: 2018-11-22 01:34:56 +0100
Test: TESTMYCOMPUTER
Class: SpecialFolders.testgroup
File: ...\ooRexx\extensions\platform\windows\ole\SpecialFolders.testGroup
Line: 324
Failed: assertTrue
Expected: 1
Actual: 0
[failure] 20210219 19:30:09.025000
svn: r11522 Change date: 2018-11-22 01:34:56 +0100
Test: TESTSTARTUP
Class: SpecialFolders.testgroup
File: ...\ooRexx\extensions\platform\windows\ole\SpecialFolders.testGroup
Line: 188
Failed: assertTrue
Expected: 1
Actual: 0
[failure] 20210219 19:30:14.181000
svn: r11522 Change date: 2018-11-22 01:34:56 +0100
Test: TEST_GETFIRST02
Class: WindowsEventLog.testGroup
File:
...\ooRexx\extensions\platform\windows\rxwinsys\WindowsEventLog.testGroup
Line: 285
Failed: assertTrue
Expected: 1
Actual: 0
Message: Working with Parameters log
[failure] 20210219 19:30:14.196000
svn: r11522 Change date: 2018-11-22 01:34:56 +0100
Test: TEST_GETLAST02
Class: WindowsEventLog.testGroup
File:
...\ooRexx\extensions\platform\windows\rxwinsys\WindowsEventLog.testGroup
Line: 255
Failed: assertTrue
Expected: 1
Actual: 0
Message: Working with Parameters log
[failure] 20210219 19:30:14.243000
svn: r11522 Change date: 2018-11-22 01:34:56 +0100
Test: TEST_GETNUMBER02
Class: WindowsEventLog.testGroup
File:
...\ooRexx\extensions\platform\windows\rxwinsys\WindowsEventLog.testGroup
Line: 225
Failed: assertTrue
Expected: 1
Actual: 0
Message: Working with Parameters log
[failure] 20210219 19:30:14.337000
svn: r11522 Change date: 2018-11-22 01:34:56 +0100
Test: TEST_OPEN_CLOSE
Class: WindowsEventLog.testGroup
File:
...\ooRexx\extensions\platform\windows\rxwinsys\WindowsEventLog.testGroup
Line: 474
Failed: assertSame
Expected: 0
Actual: 87
Message: Working with Parameters
[failure] 20210219 19:30:48.352000
svn: r11522 Change date: 2018-11-22 01:34:56 +0100
Test: TEST_READRECORDS04
Class: WindowsEventLog.testGroup
File:
...\ooRexx\extensions\platform\windows\rxwinsys\WindowsEventLog.testGroup
Line: 516
Failed: assertSame
Expected: 0
Actual: 1314
[error] 20210219 19:30:14.165000
svn: r11522 Change date: 2018-11-22 01:34:56 +0100
Test: TEST_CURRENTHANDLE_ATTRIBUTE
Class: WindowsEventLog.testGroup
File:
...\ooRexx\extensions\platform\windows\rxwinsys\WindowsEventLog.testGroup
Event: [SYNTAX 97.2] raised unexpectedly.
Object "a WindowsEventLog" cannot accept private message "CURRENTHANDLE"
from this context.
Line: 150
150 *-* obj = l~currentHandle
*-* Compiled method "SEND" with scope "Message".
1561 *-* .message~new(self, methodName)~send
1536 *-* self~doTheTest(fName, aTestResult) -- carry out the testmethod
552 *-* test~execute(testResult, verbose)
552 *-* test~execute(testResult, verbose)
110 *-* suite~execute(testResult)
79 *-* retCode = 'worker.rex'(arguments)
[Skipped test group] 20210219 19:25:42.321000
File: ...\ooRexx\API\classic\CLASSIC.testGroup
The test container has no executable tests
This is a native API test and not included in the test types to execute.
[Skipped test group] 20210219 19:25:42.337000
File: ...\ooRexx\API\oo\CONVERSION.testGroup
The test container has no executable tests
This is a native API test and not included in the test types to execute.
[Skipped test group] 20210219 19:25:42.337000
File: ...\ooRexx\API\oo\FUNCTION.testGroup
The test container has no executable tests
This is a native API test and not included in the test types to execute.
[Skipped test group] 20210219 19:25:42.337000
File: ...\ooRexx\API\oo\INVOCATION.testGroup
The test container has no executable tests
This is a native API test and not included in the test types to execute.
[Skipped test group] 20210219 19:25:42.337000
File: ...\ooRexx\API\oo\METHOD.testGroup
The test container has no executable tests
This is a native API test and not included in the test types to execute.
[Skipped test group] 20210219 19:25:42.353000
File: ...\ooRexx\API\oo\ProcessInvocation.testGroup
The test container has no executable tests
This is a native API test and not included in the test types to execute.
[Skipped test group] 20210219 19:25:42.353000
File: ...\ooRexx\API\oo\ProcessRexxStart.testGroup
The test container has no executable tests
This is a native API test and not included in the test types to execute.
[Skipped test group] 20210219 19:25:42.353000
File: ...\ooRexx\API\oo\RexxStart.testGroup
The test container has no executable tests
This is a native API test and not included in the test types to execute.
[Skipped test group] 20210219 19:25:43.712000
File: ...\ooRexx\base\rexxutil\platform\unix\SysGetMessage.testGroup
The test container has no executable tests
Test is a MACOSX FREEBSD DARWIN LINUX AIX SUNOS NETBSD CYGNUS specific test.
Current OS is: WINDOWS
[Skipped test group] 20210219 19:25:43.712000
File: ...\ooRexx\base\rexxutil\platform\unix\tilde.testGroup
The test container has no executable tests
Test is a MACOSX FREEBSD DARWIN LINUX AIX SUNOS NETBSD CYGNUS specific test.
Current OS is: WINDOWS
[Skipped test group] 20210219 19:25:43.931000
File: ...\ooRexx\doc\rexxref\chapter7\Section4.testGroup
The test container has none of the specified test types
Specified Test Types: Sample Gui Gui_sample Ole Doc_example English_only
Unit Unit_long
[Skipped test group] 20210219 19:25:43.962000
File: ...\ooRexx\extensions\platform\unix\rxunixsys\SysUnix.testGroup
The test container has no executable tests
Test is a MACOSX FREEBSD DARWIN LINUX AIX SUNOS NETBSD CYGNUS specific test.
Current OS is: WINDOWS
Interpreter: REXX-ooRexx_5.0.0(MT)_64-bit 6.05 15 Feb 2021
OS Name: WindowsNT
SysVersion: Windows 10.0.19041
Tests ran: 23373
Assertions: 389418
Failures: 13
(Known failures:) 4
Errors: 1
Exceptions: 0
Skipped files: 12
Messages: 0
Logs: 0
File search: 00:00:03.156000
Suite construction: 00:00:00.797000
Test execution: 00:05:30.953000
Total time: 00:05:35.296000
>
> I can do this AFTER I have finished the modifications for running samples
> test cases on macOS, I am in the middle of testing them (37 new test groups)
> but I do not want to commit anything that breaks anything else.
>
> Hälsningar/Regards/Grüsse,
> P.O. Jonsson
> oor...@jonases.se <mailto:oor...@jonases.se>
>
>
>
>> Am 19.02.2021 um 18:05 schrieb René Jansen <rvjan...@xs4all.nl
>> <mailto:rvjan...@xs4all.nl>>:
>>
>> Yes, but my point is, I don’t want that. I do want the tests to succeed on a
>> non-installed build. I don’t think being able to find rexxtry.rex is a test
>> for a working interpreter. If we want to test the lookup facility, we should
>> specify a file that is, or needs to be on the $PATH. There are lots of other
>> samples beside rexxtry.rex that are non-essential for the purpose of this
>> test, which is to determine if a change broke functionality on a platform
>> and indicate that to the developer.
>>
>> But I have the copy now in the test configuration and it is fine. I thought
>> it better for conceptual integrity and fit-for-purpose to remove the test
>> but when you all disagree it is no problem; case closed.
>>
>> best regards,
>>
>> René.
>>
>>> On 19 Feb 2021, at 16:44, Rony G. Flatscher <rony.flatsc...@wu.ac.at
>>> <mailto:rony.flatsc...@wu.ac.at>> wrote:
>>>
>>> On 19.02.2021 15:28, rvjan...@xs4all.nl <mailto:rvjan...@xs4all.nl> wrote:
>>>> Ok, will add it to the path like P.O. suggested and hope that it works. Or
>>>> will copy it after the build. I think it tests the install process and not
>>>> the working of the interpreter.
>>> You can test the existence of rexxtry.rex next to rexx[.exe] by something
>>> like e.g.
>>>
>>> self~assertTrue(SysFileExists(filespec("location",.rexxinfo~executable)||"rexxtry.rex"))
>>> ---rony
>>>
>>>>> On 19 Feb 2021, at 14:55, Rony G. Flatscher <rony.flatsc...@wu.ac.at>
>>>>> <mailto:rony.flatsc...@wu.ac.at> wrote:
>>>>>
>>>>> On 18.02.2021 15:49, René Jansen wrote:
>>>>>> There is currently only one test case failing on the Linux on Z
>>>>>> Rockhopper, which is the test for the reachability of RexxTry. This is
>>>>>> because this is the uninstalled version of ooRexx - the so-called USB
>>>>>> version. I expect this to fail on other machines where we do not do an
>>>>>> install, because RexxTry has not been copied from samples to the $PATH.
>>>>>>
>>>>>> I want to remove this test, does anyone oppose?
>>>>> hmm, as "rexxtry.rex" has *always* been put into the location where the
>>>>> executable rexx[.exe]
>>>>> resided I would regard this a bug in the USB version you used which
>>>>> should place "rexxtry.rex" next
>>>>> to rexx[.exe]. As such the test unveiled this error and I would keep it!
>>>>> :)
>>>>>
>>>>> ---rony
>>>
>>> _______________________________________________
>>> Oorexx-devel mailing list
>>> Oorexx-devel@lists.sourceforge.net
>>> <mailto:Oorexx-devel@lists.sourceforge.net>
>>> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>>> <https://lists.sourceforge.net/lists/listinfo/oorexx-devel>
>>
>> _______________________________________________
>> Oorexx-devel mailing list
>> Oorexx-devel@lists.sourceforge.net
>> <mailto:Oorexx-devel@lists.sourceforge.net>
>> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>> <https://lists.sourceforge.net/lists/listinfo/oorexx-devel>
>
> _______________________________________________
> Oorexx-devel mailing list
> Oorexx-devel@lists.sourceforge.net <mailto:Oorexx-devel@lists.sourceforge.net>
> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
> <https://lists.sourceforge.net/lists/listinfo/oorexx-devel>
> _______________________________________________
> Oorexx-devel mailing list
> Oorexx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
_______________________________________________
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel
