Am 24.03.2021 um 19:34 schrieb Erich Steinböck <erich.steinbo...@gmail.com>: > > Hi P.O., re your recently committed additional test groups for Samples: > > all testGroup files should have set these three SVN properties: > svn propset svn:eol-style native name.testGroup > svn propset svn:executable on name.testGroup > svn propset svn:keywords "Date Rev“ name.testGroup
I started from an existing sample testGroup and took it from there some two years ago. I will recheck and amend as requested but it will take some time. > > Also testGroup files are expected to have proper headers - exactly like below: > #!/usr/bin/env rexx > /* > SVN Revision: $Rev$ > Change Date: $Date$ > */ Ok > > Your testGroup template defines global variables like shouldStop that aren't > actually used anywhere. > This includes a variable stopStop which is actually a typo. Leftovers from earlier das, will cleanup. Remember I started out with zip knowledge about testing. > > There's no need to special-case ADDRESS "" vs. ADDRESS COMMAND. > Cross-platform ADDRESS formats include ADDRESS SYSTEM or ADDRESS "" > > The main tests run the samples with an explicit REXX external command. They > should be run with execRexxPrg() instead. > Ok will change > Your test groups typically run the tested sample twice, which shouldn't be > necessary. Once run, return code and output tests can be done at the same > time. There's also no need to test for a 9999 return code (this was just an > internal quirk that I've removed). > The first test is just to see if it launches, 2nd test typically with illegal input, do you want me to remove all those? The do not hurt imo. > Also to simplify maintenance you might check out the template that I just > committed: wmi.testGroup uses a single test per sample, making the tests > easier to understand and more concise. Will check it out. > _______________________________________________ > Oorexx-devel mailing list > Oorexx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/oorexx-devel _______________________________________________ Oorexx-devel mailing list Oorexx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oorexx-devel
