On 10.06.2021 18:19, Erich Steinböck wrote:
>
>     suggesting to use this 'json.cls' version to replace the old version, if 
> there are no objections 
>
> I don't like it,

What is it that you do not like specifically and why?


> not least because it's 50% slower than what we have.

Hmm, how do you come up with that number?

Here my findings (three runs each starting out in a new terminal running the 
current json.testGroup):

- current json.cls:

    Test execution:     00:00:00.184000
    Test execution:     00:00:00.039000
    Test execution:     00:00:00.039000

- sandbox json.cls:

    Test execution:     00:00:00.060000
    Test execution:     00:00:00.042000
    Test execution:     00:00:00.042000

So

    rexx -e "say 42/39"

yields

    1.07692308

Or 7,69% slower but doing  more work (so nothing even close to your 50%).

[Used platform is Windows, "Windows 10.0.19042", ooRexx revision is: r12249.]


> Also please no rip-and-replace code rewrites; if something is broken (.nil 
> <--> "null" ?) open a
> bug, or if something needs to get enhanced, open a feature request.

?

Sorry, have no clue what you mean, seriously! Please explain.

---

Ad enhancements: yes there are a few, intended to

  * a) match the current JSON specifications (like the sandbox json.cls being 
able to encode a Rexx
    .true as a JSON "true" and .false as a JSON "false", trying to make it as 
easy and transparent
    to the ooRexx programmer as much as possible, hence the private class 
JsonBoolean class that
    gets used to return the .json~true or .json~false objects which can be used 
interchangeably with
    ooRexx .true/.false, but makes it possible to encode the logical values 
transparently to the
    correct JSON representation) to allow true exchange with non-Rexx peers and

  * b) ease the ooRexx programmer's work (like allowing any OrderableCollection 
and MapCollection to
    be encodeable as JSON, not only .Directory or .Array, or support the ooRexx 
logical values
    .true/.false as mentioned to their proper JSON encodings, or, enable an 
ooRexx programmer to
    have his class render to JSON the way he sees to fit best, if necessary).

The link to the current JSON specifications are given in the sandbox' json.cls 
source code and also
in the generated help text, i.e.: <https://www.rfc-editor.org/info/rfc8259>, at 
the top click on the
icons for txt, pdf or html.

---rony


_______________________________________________
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel

Reply via email to