In preparation of adding a new entry to TraceObject it is clear that deciding whether an entry should be added or not needs to be done as quickly as possible in CreateTraceObject(). To facilate this decision it would be good to supply the TracePrefix value for which a trace line gets output. This would incur an additional TracePrefix argument to traceOutput() and to CreateTraceObject() in which the TracePrefix value could then be tested.

While going through the invocations of traceOutput(...) all but the following two routines have proper TracePrefix values defined for them:

 *

   void RexxActivation::traceSourceString()

 *

   bool RexxActivation::doDebugPause()

Therefore the idea is to define two new TracePrefix enum values that allow to identify the reason of the call to traceOutput():

 * TRACE_SOURCE_STRING ... intended for use in --> void 
RexxActivation::traceSourceString()
 * TRACE_DEBUG_PROMPT ... intended for use in the initial debug prompt --> bool
   RexxActivation::doDebugPause()

Alternatively, one could add an enum value TRACE_UNDEFINED for use in traceSourceString() and doDebugPause() when invoking traceOutput(). Personally I would prefer to communicate the exact reason for the trace line output.

Any comments?

---rony

_______________________________________________
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel

Reply via email to