----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6073/#review10533 -----------------------------------------------------------
patch looks good..some last comments.. trunk/core/src/main/java/org/apache/oozie/BulkResponseInfo.java <https://reviews.apache.org/r/6073/#comment22540> javadoc trunk/core/src/main/java/org/apache/oozie/client/rest/BulkResponseImpl.java <https://reviews.apache.org/r/6073/#comment22541> javadoc..same comment for all public things in this class trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkMonitorJPAExecutor.java <https://reviews.apache.org/r/6073/#comment22545> space between comma and brList is required..same comment for other places..plz apply the formatter trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkMonitorJPAExecutor.java <https://reviews.apache.org/r/6073/#comment22546> catch starts on next line as per convention..same comment for other places.. trunk/core/src/test/java/org/apache/oozie/servlet/TestBulkMonitorWebServiceAPI.java <https://reviews.apache.org/r/6073/#comment22547> if this function is very similar or same to the one in other test case, a public static method can be created trunk/docs/src/site/twiki/WebServicesAPI.twiki <https://reviews.apache.org/r/6073/#comment22544> why is this removed? - Virag Kothari On Aug. 16, 2012, 8:33 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6073/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2012, 8:33 p.m.) > > > Review request for oozie. > > > Description > ------- > > First draft of the implementation of Bulk Monitoring API - RESTful WS API to > traverse through bulk of multiple Oozie job levels and find the > actions/workflows based on multiple filtering criteria > > This is WIP > - refining API > - testing to see results > > Uploading the patch to give a flavor of the implementation following design > reviews > > > This addresses bug OOZIE-848. > https://issues.apache.org/jira/browse/OOZIE-848 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1373166 > trunk/client/src/main/java/org/apache/oozie/client/BulkResponse.java > PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1373166 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java > 1373166 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java > 1373166 > trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1373166 > trunk/core/src/main/java/org/apache/oozie/BulkResponseInfo.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/BundleEngine.java 1373166 > trunk/core/src/main/java/org/apache/oozie/client/rest/BulkResponseImpl.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/command/BulkJobsXCommand.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobsServlet.java > 1373166 > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java > 1373166 > trunk/core/src/main/java/org/apache/oozie/util/DateUtils.java 1373166 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkMonitorJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/servlet/TestBulkMonitorWebServiceAPI.java > PRE-CREATION > trunk/docs/src/site/twiki/WebServicesAPI.twiki 1373166 > > Diff: https://reviews.apache.org/r/6073/diff/ > > > Testing > ------- > > not yet > > > Thanks, > > Mona Chitnis > >
