> On Aug. 17, 2012, 6:34 p.m., Mona Chitnis wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 176 > > <https://reviews.apache.org/r/6422/diff/2/?file=141804#file141804line176> > > > > the error gets thrown from this block itself and not registerError; > > while parsing the argument to be passed to registerError - which is the > > missing class - the error gets thrown. So catch required here > > > > Since exceptions caught are being propagated, why shouldnt errors > > caught be propagated as well? > > > >
the arg to registerError is a String which cannot throw NoClassDefError, so this exception needs to be pushed to registerError and as discussed not to be propagated to parent.. other than that, patch looks good..plz attach the final patch here and to jira after making changes.. - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6422/#review10468 ----------------------------------------------------------- On Aug. 16, 2012, 11:55 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6422/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2012, 11:55 p.m.) > > > Review request for oozie. > > > Description > ------- > > During Oozie server startup, some of the services e.g. ActionService, if they > encounter an exception during initialization, the exception is not propagated > to the caller. As a result, shutdown occurs without any leads in the logs. > Exception handling needs to be improved for services init. > > > This addresses bug OOZIE-934. > https://issues.apache.org/jira/browse/OOZIE-934 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1374096 > trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java > 1374096 > > trunk/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java > 1374096 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1374096 > > trunk/core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java > 1374096 > trunk/core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java > 1374096 > trunk/core/src/main/java/org/apache/oozie/service/ActionService.java > 1374096 > trunk/core/src/main/java/org/apache/oozie/service/GroupsService.java > 1374096 > trunk/core/src/main/java/org/apache/oozie/service/Services.java 1374096 > trunk/core/src/test/java/org/apache/oozie/action/TestActionExecutor.java > 1374096 > > Diff: https://reviews.apache.org/r/6422/diff/ > > > Testing > ------- > > tested with some use cases > e.g. - wrong oozie property values > - missing classes > > > Thanks, > > Mona Chitnis > >
