[
https://issues.apache.org/jira/browse/OOZIE-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445403#comment-13445403
]
Alejandro Abdelnur commented on OOZIE-981:
------------------------------------------
patch looks good, only NIT is
{code}
+ // if property already exists, should not overwrite
+ if(conf.get(name) != null) {
+ continue;
+ }
+ conf.set(name, value);
{code}
I'd do instead:
{code}
+ // if property already exists, should not overwrite
+ if(conf.get(name) == null) {
+ conf.set(name, value);
+ }
{code}
> Subworkflow lib not found in classpath when parent workflow lib overwrites it
> -----------------------------------------------------------------------------
>
> Key: OOZIE-981
> URL: https://issues.apache.org/jira/browse/OOZIE-981
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: 3.3.0
>
> Attachments: OOZIE-981.patch
>
>
> OOZIE-567 addresses the bug mentioned in the title here - by adding the
> subworkflow libpath to the classpath in addition to parent workflow libpath.
> OOZIE-871 reverted this to avoid duplicate values, but the subworkflow
> libpath should not be overwritten by parent workflow's libpath. Hence,
> tackling this bug here.
> Existing testcase modified slightly to demonstrate the expected behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
