[
https://issues.apache.org/jira/browse/OOZIE-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449104#comment-13449104
]
Robert Kanter commented on OOZIE-975:
-------------------------------------
Looks good to me.
The only thing would be that instead of having 5 almost identical copies of the
{{private void setClassesToBeExcluded(Configuration conf)}} method, maybe it
would be better to move the method definition to the parent class,
XDataTestCase and have an array or varargs argument to take the services to
disable; e.g.
{{protected void setClassesToBeExcluded(Configuration conf, String[]
excludedServices)}} or
{{protected void setClassesToBeExcluded(Configuration conf, String...
excludedServices)}}
This would also allow any future new tests to use this without copying the
code.
> Test cases should not load all the services classes
> ---------------------------------------------------
>
> Key: OOZIE-975
> URL: https://issues.apache.org/jira/browse/OOZIE-975
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Virag Kothari
> Assignee: Virag Kothari
> Fix For: trunk
>
> Attachments: kill-output.txt, OOZIE-975.patch
>
>
> Some services classes loaded as part of services.init() interfere with the
> actual test case causing them to break.
> TestPauseTransitSErvice, TestPurgeService, TestActionCheckerService keep
> failing intermittently.
> Related pre-commit build links:
> https://builds.apache.org/job/oozie-trunk-precommit-build/58/testReport/junit/org.apache.oozie.service/TestPauseTransitService/testUnpauseBundleAndCoordinator/
> https://builds.apache.org/job/oozie-trunk-precommit-build/55/testReport/junit/org.apache.oozie.service/TestActionCheckerService/testActionCheckerServiceCoord/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
