So I did refresh the bulk-ocamlbuild-update PR on top of Louis' changes, and the result is indeed much nicer.
The updated PR is still at https://github.com/ocaml/opam-repository/pull/5140 On Fri, Nov 27, 2015 at 10:53 AM, Gabriel Scherer <[email protected] > wrote: > Perfect, thanks! I plan to do the forward-porting and refresh my PR > this week-end; if you haven't gotten to adding the quoting option by > then, no worries, I'll just hack it as a temporary patch in my local > branch. > > On Fri, Nov 27, 2015 at 10:46 AM, Louis Gesbert > <[email protected]> wrote: > >> With this solution, you still lose comments on the modified fields > >> (we've seen in the examples above that for examples there are comments > >> inside the depext or depopt fields). The general guarantee you provide > >> to users is still "best effort, comments may disappear". > > > > Indeed. > > > >> Do you plan to cherry-pick the format-preserving-printer on top of > >> some 1.2 branch? I'm fine with porting my own script back to trunk, > >> but I wonder whether I will have the same incompatible-formatting > >> issues as last time (where those clear bugs that you fixed, or just a > >> change in expected format?). > > > > No, it's not reasonably doable since parsing/printing has been largely > > rewritten and the whole format-preserving stuff is based on functions > that > > didn't exist. > > > > The '"""' quoted strings are the only format update in the > parser/printer, so > > I'll add an option to disable their automatic use when printing and use > that > > in the rewriting scripts (it wasn't strictly required, but we wanted to > be > > able do include the package descriptions in the opam file, and it makes > > escaping much less painful). With that fix you should be good on trunk. >
_______________________________________________ opam-devel mailing list [email protected] http://lists.ocaml.org/listinfo/opam-devel
