On Thu, 2008-05-22 at 17:15 -0400, Christoph Hellwig wrote: > > +struct bnx2i_async_msg { > > +#if defined(__BIG_ENDIAN) > > + u8 op_code; > > + u8 reserved1; > > + u16 reserved0; > > +#elif defined(__LITTLE_ENDIAN) > > + u16 reserved0; > > + u8 reserved1; > > + u8 op_code; > > +#endif > > + u32 reserved2; > > + u32 exp_cmd_sn; > > + u32 max_cmd_sn; > > + u32 reserved3[2]; > > Please don't do the ifdef big endian mess. Just read the whole > 32bit word and do mask and shift operations to extract the actual value. > >
I agree with you that u32 is cleaner in some cases. We can just change it to u32 op_code and we just need a OP_CODE_MASK of 0xff. We'll go through this .h file and remove some of this big endian stuff and also the duplicate constants pointed out earlier. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/open-iscsi -~----------~----~----~----~------~----~------~--~---