Thanks for catching this bug Thomas and testing this bug Narendra. The patch looks good.
Reviewed-by: Benjamin Li <be...@broadcom.com> On Tue, 2009-09-29 at 09:03 -0700, shyam_i...@dell.com wrote: > 1. Install Red Hat Enterprise Linux 5.4 snapshot 5 i386 on a server with > Broadcom iSCSI offload capable LOMs. > *** Note: 32-bit OS believed necessary *** > 2. Discover an iSCSI target on the local IP network using the offload > interface. > iscsiadm -m discovery -p <ip_addr> -t st -I bnx2i.<offload_mac> > 3. Configure the offload interface to use DHCP. > iscsiadm -m iface -I bnx2i -o update -n iface.ipaddress -v 0.0.0.0 > 4. Attempt to connect to the iSCSI target. > iscsiadm -m node -l > 5. Observe that the connection attempt eventually times out. > > This bug affects the upstream versions of the cnic code as well. > > Signed-off-by: Thomas Chenault <thomas_chena...@dell.com > > Tested-by: Narendra K <narendr...@dell.com> > > --- > open-iscsi-2.0-871-test4.bnx2i/brcm_iscsi_uio/src/unix/libs/cnic_nl.c > 2009-08-18 23:03:34.000000000 -0500 > +++ > open-iscsi-2.0-871-test4.bnx2i.new/brcm_iscsi_uio/src/unix/libs/cnic_nl. > c 2009-08-18 23:06:12.000000000 -0500 > @@ -124,7 +124,7 @@ > path_rsp->ip_addr_len = 4; > memcpy(&path_rsp->src.v4_addr, &nic_iface->ustack.hostaddr, > sizeof(nic_iface->ustack.hostaddr)); > - memcpy(path_rsp->mac_addr, mac_addr, sizeof(mac_addr)); > + memcpy(path_rsp->mac_addr, mac_addr, 6); > path_rsp->vlan_id = path_req->vlan_id; > path_rsp->pmtu = path_req->pmtu; > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~----------~----~----~----~------~----~------~--~---
