On Thu, 2013-12-19 at 16:06 +0100, Levente Kurusa wrote: > This is required so that we give up the last reference to the device.
This isn't true. > Remove the kfree() as well, because the put_device() will result in > iscsi_endpoint_release being called and hence it will be kfree'd. There's no real point to this patch. The use case where we own the device absolutely up until the point we hand out references is well established and there are a number of destroy paths running through SCSI code which don't go via refcounting and this is one of them. They're almost universally on error legs on device bring up as this one is. James -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/groups/opt_out.