On 02/01/2014 06:37 AM, Mike Christie wrote:
On 1/29/14 4:19 AM, Hannes Reinecke wrote:
For proper operations we need to set gateway and subnet_mask
of the individual interfaces. Not every target is connected
to the local network.
Signed-off-by: Hannes Reinecke <h...@suse.de>
---
usr/idbm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/usr/idbm.c b/usr/idbm.c
index 1ade099..9f3e567 100644
--- a/usr/idbm.c
+++ b/usr/idbm.c
@@ -262,6 +262,8 @@ idbm_recinfo_node(node_rec_t *r, recinfo_t *ri)
__recinfo_str(IFACE_IPADDR, ri, r, iface.ipaddress, IDBM_SHOW,
num, 1);
__recinfo_str(IFACE_ISCSINAME, ri, r, iface.name, IDBM_SHOW,
num, 1);
__recinfo_str(IFACE_NETNAME, ri, r, iface.netdev, IDBM_SHOW,
num, 1);
+ __recinfo_str(IFACE_GATEWAY, ri, r, iface.gateway, IDBM_SHOW,
num, 1);
+ __recinfo_str(IFACE_SUBNET_MASK, ri, r, iface.subnet_mask,
IDBM_SHOW, num, 1);
/*
* svn 780 compat: older versions used node.transport_name and
* rec->transport_name
Is this still needed? A little before above we have
iface_type = iface_get_iptype(&r->iface);
which should be returning ISCSI_IFACE_TYPE_IPV4. Then a little further
from the code your patch added we have:
if (iface_type == ISCSI_IFACE_TYPE_IPV4) {
__recinfo_str(IFACE_BOOT_PROTO, ri, r, iface.bootproto,
IDBM_SHOW, num, 1);
__recinfo_str(IFACE_SUBNET_MASK, ri, r, iface.subnet_mask,
IDBM_SHOW, num, 1);
__recinfo_str(IFACE_GATEWAY, ri, r, iface.gateway,
IDBM_SHOW,
num, 1);
Right, so we can drop this. Thanks for the pointer.
(I'm currently flushing our SUSE-specific patches, which for some reason
we never managed to send upstream. So I'm not surprised that
this patch is obsolete.)
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/groups/opt_out.
