On Nov 13, 2014, at 5:56 PM, The Lee-Man <leeman.dun...@gmail.com> wrote:
> On Tuesday, November 11, 2014 8:25:56 PM UTC-8, Mike Christie wrote: > On 10/30/2014 08:16 PM, The Lee-Man wrote: > > 0002-Represent-DHCP-origin-as-an-integer-not-string.patch > > > > This just changes the "origin" attribute from a string, to a number, > > which > > is what it really is. > > > > Could you send me a link to where origin is defined? In the doc I have > it is a dead link. > > This is defined in the iBFT document, available here on the web here: iBFT > Layout - Microsoft > (if my hper-link works) > > In section 3.6 NIC Structure, the table shows that "origin" 1 byte long at > offset 23 bytes. And table points at a C++ definition of the values here: > http://msdn.microsoft.com/en-us/library/aa366281.aspx > > It looks like: > > typedef enum { > IpPrefixOriginOther = 0, > IpPrefixOriginManual, > IpPrefixOriginWellKnown, > IpPrefixOriginDhcp, > IpPrefixOriginRouterAdvertisement, > IpPrefixOriginUnchanged = 16 > } IP_PREFIX_ORIGIN; > The open-iscsi code current checks this for the value "3" (i.e. a string > representing the number 3), and our code already has a patch that instead > reads this value in as an integer, and then compares it with the number 3. Could you add a enum for these values in fw_context.h and then check for it instead of the numerical value? -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
