On 03/31/2015 12:44 PM, Thomas Dwyer III wrote: > Currently, open-iscsi ignores iface.ipaddress whether or not > iface.net_ifacename is configured. This can be problematic if/when a > network interface is configured with multiple IP addresses and a target > only allows connections from one of them. This patch adds support for > iface.ipaddress, calling bind() and/or setsockopt(SO_BINDTODEVICE) > depending on which iface parameters are changed from their default > values. In other words, the following combinations are now permitted (1 > & 2 are current behavior, 3 & 4 are new behavior): > > 1. Neither of iface.net_ifacename and iface.ipaddress are configured. > The code lets the operating system choose an appropriate local IP > address and interface based on the portal address. > 2. Only iface.net_ifacename is configured. The code calls > setsockopt(SO_BINDTODEVICE) and then lets the operating system > choose an appropriate local IP address. > 3. Only iface.ipaddress is configured. The code calls bind() and lets > the operating system choose an appropriate interface. > 4. Both of iface.net_ifacename and iface.ipaddress are configured. The > code calls both bind() and setsockopt(SO_BINDTODEVICE). The > administrator must ensure that the combination of > iface.net_ifacename and iface.ipaddress is an appropriate configuration. >
Hey, Thanks for working on this. So, did you test it out and it did what you needed? In that other thread I said I had thought I had made some change between the time I had originally did that code and now that might have broken it, but was not sure. If its working for you then I will merge it up. -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
