On 7/10/19 12:30 AM, Yang Bin wrote: > From: " Yang Bin "<yang.bi...@zte.com.cn> > > Before xmit,iscsi may disconnect just now. > So must check connection sock NULL or not,or kernel will crash for > accessing NULL pointer. > > Signed-off-by: Yang Bin <yang.bi...@zte.com.cn> > --- > drivers/scsi/iscsi_tcp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c > index 7bedbe8..a59c49f 100644 > --- a/drivers/scsi/iscsi_tcp.c > +++ b/drivers/scsi/iscsi_tcp.c > @@ -264,6 +264,9 @@ static int iscsi_sw_tcp_xmit_segment(struct > iscsi_tcp_conn *tcp_conn, > unsigned int copied = 0; > int r = 0; > > + if (!sk) > + return -ENOTCONN; > + > while (!iscsi_tcp_segment_done(tcp_conn, segment, 0, r)) { > struct scatterlist *sg; > unsigned int offset, copy; >
If the socket can be closed right before iscsi_sw_tcp_xmit_segment() is called, can it be called in the middle of sending segments? (In which case the check would have to be in the while loop.) -- Lee Duncan -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at https://groups.google.com/group/open-iscsi. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/1bc364ff-5bff-47ac-611a-f75c43f4bd1b%40suse.com. For more options, visit https://groups.google.com/d/optout.