On Thursday, June 4, 2020 at 5:10:49 AM UTC-7, Wu Bo wrote:
>
> From: liubo <liubo...@huawei.com>
>
> Fix the potential risk of rc value being washed out by jumping out of the
> loop
>
> Signed-off-by: liubo <liubo...@huawei.com>
> Reported-by: Zhiqiang Liu <liuzhiqian...@huawei.com>
> ---
> utils/fwparam_ibft/fwparam_sysfs.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/utils/fwparam_ibft/fwparam_sysfs.c
> b/utils/fwparam_ibft/fwparam_sysfs.c
> index a0cd1c7..87fd6d4 100644
> --- a/utils/fwparam_ibft/fwparam_sysfs.c
> +++ b/utils/fwparam_ibft/fwparam_sysfs.c
> @@ -115,8 +115,11 @@ static int get_iface_from_device(char *id, struct
> boot_context *context)
> break;
> }
>
> - if (sscanf(dent->d_name, "net:%s",
> context->iface) != 1)
> + if (sscanf(dent->d_name, "net:%s",
> context->iface) != 1) {
> rc = EINVAL;
> + break;
> + }
> +
> rc = 0;
> break;
> } else {
> --
> 2.21.0.windows.1
>
>
This looks fine to me. Any chance you could submit a pull request on
GitHub? It saves me having to cut-and-paste, since I sadly do not have a
good workflow setup for patches from the mailing list.
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to open-iscsi+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/open-iscsi/a167b02a-53af-48ce-907a-5e43c67dd086o%40googlegroups.com.
